Regional BC blending and BCs into GSI by TomBlack-NOAA · Pull Request #16 · NOAA-EMC/GFDL_atmos_cubed_sphere

TomBlack-NOAA · 2020-03-12T15:39:03Z

Associated PRs:
ufs-community/ufs-weather-model#83
NOAA-EMC/ufsatm#80

junwang-noaa · 2020-04-03T13:14:53Z

+      do k=1, Atm(n)%npz
+      do j=lbound(Atm(n)%pt,2),ubound(Atm(n)%pt,2)
+      do i=lbound(Atm(n)%pt,1),ubound(Atm(n)%pt,1)
+        if(Atm(n)%pt(i,j,k)>400.)then


This can be added later, but If we have bad Temperature >400, can we stop model from continue running (call mpp_error)?

If you turn on the namelist "range_warn" the call to fv_diag will check the temperature for the data domain. An FMS "NOTE" will be emitted for temperatures outside the range of (150 - 350).

Let's remove this block since I'm sure I put it there for debugging.

junwang-noaa · 2020-04-03T13:25:27Z

@@ -260,6 +311,7 @@ subroutine setup_regional_BC(Atm                                  &
      east_bc =.false.
      west_bc =.false.
 !
+   write(0,*)' enter setup_regional_BC isd=',isd,' ied=',ied,' jsd=',jsd,' jed=',jed    


We may want to comment this line or make it option whether to print out this line? This could be part of the job error file clean up work.

Let's just comment out the line. I know it's very valuable for dealing with some MPI-related problems so it's nice to have it sitting there.

TomBlack-NOAA · 2020-04-03T13:27:49Z

Jun, That block is probably left over from debugging that I missed removing so it's fine to take it out. Tom

…

On 4/3/2020 9:15 AM, Jun Wang wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In driver/fvGFS/atmosphere.F90 <#16 (comment)>: > @@ -1630,6 +1630,18 @@ subroutine atmosphere_state_update (Time, IPD_Data, IAU_Data, Atm_block, flip_vc call nullify_domain() call timing_on('FV_DIAG') + + do k=1, Atm(n)%npz + do j=lbound(Atm(n)%pt,2),ubound(Atm(n)%pt,2) + do i=lbound(Atm(n)%pt,1),ubound(Atm(n)%pt,1) + if(Atm(n)%pt(i,j,k)>400.)then This can be added later, but If we have bad Temperature >400, can we stop model from continue running? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQGGOZOMHRT4FRQRG6ZZJTRKXONZANCNFSM4LGPBKUQ>.

TomBlack-NOAA · 2020-04-03T13:29:32Z

Jun, We would at least need the option to print those values. They can be very valuable when debugging and when adding/modifying the code. Tom

…

On 4/3/2020 9:25 AM, Jun Wang wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In model/fv_regional_bc.F90 <#16 (comment)>: > @@ -260,6 +311,7 @@ subroutine setup_regional_BC(Atm & east_bc =.false. west_bc =.false. ! + write(0,*)' enter setup_regional_BC isd=',isd,' ied=',ied,' jsd=',jsd,' jed=',jed We may want to comment this line or make it option whether to print out this line? This could be part of the job error file clean up work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#16 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALQGGO6V7J2VBSP7MNNOYHTRKXPVPANCNFSM4LGPBKUQ>.

bensonr

Are the *_65lyrs and *_NAM_lyrs files test files from previous work? If so, please delete them from the merge. If they are necessary, please document the need for them.

bensonr · 2020-04-03T15:20:54Z

+      do k=1, Atm(n)%npz
+      do j=lbound(Atm(n)%pt,2),ubound(Atm(n)%pt,2)
+      do i=lbound(Atm(n)%pt,1),ubound(Atm(n)%pt,1)
+        if(Atm(n)%pt(i,j,k)>400.)then


If you turn on the namelist "range_warn" the call to fv_diag will check the temperature for the data domain. An FMS "NOTE" will be emitted for temperatures outside the range of (150 - 350).

bensonr · 2020-04-03T15:23:57Z

+!*                   GNU General Public License                        *
+!* This file is a part of fvGFS.                                       *
+!*                                                                     *
+!* fvGFS is free software; you can redistribute it and/or modify it    *
+!* and are expected to follow the terms of the GNU General Public      *
+!* License as published by the Free Software Foundation; either        *
+!* version 2 of the License, or (at your option) any later version.    *
+!*                                                                     *
+!* fvGFS is distributed in the hope that it will be useful, but        *
+!* WITHOUT ANY WARRANTY; without even the implied warranty of          *
+!* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU   *
+!* General Public License for more details.                            *
+!*                                                                     *
+!* For the full text of the GNU General Public License,                *
+!* write to: Free Software Foundation, Inc.,                           *
+!*           675 Mass Ave, Cambridge, MA 02139, USA.                   *
+!* or see:   http://www.gnu.org/licenses/gpl.html                      *


This license header is outdated. The one being replaced is the correct version. Please fix and push a new udpate for this file.

I'll replace this with the new header.

bensonr · 2020-04-03T15:36:12Z

+        if(is_master()) then
+          write(0,10011)nrows_blend_user,nrows_blend_in_data
+10011     format(' User wants to use ',i3,' blending rows but only '    &
+                ,i3,' blending rows are in the BC file!')
+          write(0,*)' Aborting!!!'
+        endif
+        call abort()


Please consider using the FMS error_msg function which when given the FATAL parameter will write an error message to the screen and abort gracefully.

Will replace with call to mpp_error.

bensonr · 2020-04-03T15:39:23Z

-      endif
+        regional_bc_bounds%je_east_uvs=jed+1
+        if(south_bc)then
+          regional_bc_bounds%je_east_uvs=jed-nhalo_model+1


All other uses of nhalo_model have been modified to include nrows_blend in some fashion. Should this one be modified in a similar fashion?

This is okay. It is on the east side so the I index must include blending rows extending into the integration domain. Blending on the east side (and west side) is irrelevant to the J dimension.

bensonr · 2020-04-03T15:40:42Z

 !
-!     write(0,*)' opened grid file',trim(filename)
+      write(0,*)' opened grid file ',trim(filename)


Please consider using the standard FMS error_msg function with the NOTE parameter for output of this nature.

bensonr · 2020-04-03T15:46:00Z

+!  write(0,66811)is_0,ie_0,js_0,je_0
+66811 format(' allocated delp_BC(',i3,':',i3,',',i3,':',i3,')')


Is this a debug message that is no longer needed?

Most likely. I'll remove it.

bensonr · 2020-04-03T15:53:17Z

            write(0,101)
  101       format(' iq<1 is not a valid index for q_BC array in retrieve_bc_variable_data')
+            call abort()


Please consider using FMS error_msg with the FATAL parameter to output the message and cleanly abort the model.

Will replace with mpp_error.

bensonr · 2020-04-03T15:54:52Z

+!       else
+!         if ( npz <= 64 ) then
+!            Atm(n)%ak(:) = ak_sj(:)
+!            Atm(n)%bk(:) = bk_sj(:)
+!            Atm(n)%ptop = Atm(n)%ak(1)
+!         else
+!            call set_eta(npz, ks, Atm(n)%ptop, Atm(n)%ak, Atm(n)%bk)
+!         endif


Do these lines need to be kept for documentation purposes or can they be removed?

I think they can be removed.

bensonr · 2020-04-03T15:57:06Z

+!      data a60/  1.7861000000e-01,   1.0805100000e+00,   3.9647100000e+00, &
+!                 9.7516000000e+00,   1.9816580000e+01,   3.6695950000e+01, &
+!                 6.2550570000e+01,   9.9199620000e+01,   1.4792505000e+02, &
+!                 2.0947487000e+02,   2.8422571000e+02,   3.7241721000e+02, &
+!                 4.7437835000e+02,   5.9070236000e+02,   7.2236063000e+02, &
+!                 8.7076746000e+02,   1.0378138800e+03,   1.2258877300e+03, &
+!                 1.4378924600e+03,   1.6772726600e+03,   1.9480506400e+03, &
+!                 2.2548762700e+03,   2.6030909400e+03,   2.9988059200e+03, &
+!                 3.4489952300e+03,   3.9616028900e+03,   4.5456641600e+03, &
+!                 5.2114401700e+03,   5.9705644000e+03,   6.8361981800e+03, &
+!                 7.8231906000e+03,   8.9482351000e+03,   1.0230010660e+04, &
+!                 1.1689289750e+04,   1.3348986860e+04,   1.5234111060e+04, &
+!                 1.7371573230e+04,   1.9789784580e+04,   2.2005564550e+04, &
+!                 2.3550115120e+04,   2.4468583320e+04,   2.4800548800e+04, &
+!                 2.4582445070e+04,   2.3849999620e+04,   2.2640519740e+04, &
+!                 2.0994737150e+04,   1.8957848730e+04,   1.6579413230e+04, &
+!                 1.4080071030e+04,   1.1753630920e+04,   9.6516996300e+03, &
+!                 7.7938009300e+03,   6.1769062800e+03,   4.7874276000e+03, &
+!                 3.6050497500e+03,   2.6059860700e+03,   1.7668328200e+03, &
+!                 1.0656131200e+03,   4.8226201000e+02,   0.0000000000e+00, &
+!                 0.0000000000e+00 /  
+
+
+!      data b60/ 0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   0.0000000000e+00, &
+!                0.0000000000e+00,   0.0000000000e+00,   5.0600000000e-03, &
+!                2.0080000000e-02,   4.4900000000e-02,   7.9360000000e-02, &
+!                1.2326000000e-01,   1.7634000000e-01,   2.3820000000e-01, &
+!                3.0827000000e-01,   3.8581000000e-01,   4.6989000000e-01, &
+!                5.5393000000e-01,   6.2958000000e-01,   6.9642000000e-01, &
+!                7.5458000000e-01,   8.0463000000e-01,   8.4728000000e-01, &
+!                8.8335000000e-01,   9.1368000000e-01,   9.3905000000e-01, &
+!                9.6020000000e-01,   9.7775000000e-01,   9.9223000000e-01, &
+!                1.0000000000e+00 /


Should there be an #ifdef/#else/#endif around this and the NAM level definition below to make it easier to switch back and forth between the two definitions for 60 levels?

I believe these should be removed.

bensonr · 2020-04-03T15:57:45Z

+!          ks = 37
+          ks = 19


Same as the comment above regarding #ifdef.

Likewise, let's remove it.

bensonr

I approve the changes.

* add option to output omega * VLab Issue #68141 modified: docs/FV3_citations.bib modified: model/fv_cmp.F90 1) Add an option (namelist parameter: intqs) to use temperature instead of the liquid frozen temperature to calculate saturation mixing ratio in deriving GFDLMP PDF cloud cover. 2) Add a literature reference. * Update fv_cmp.F90 to remove a bug introduced in last update. * change delz from positive value to the original value in the model * Remove TRANSITION mode * added documentation for parameter list * Merging https://github.com/valbonakunkel-noaa/GFDL_atmos_cubed_sphere, branch dev/emc, into ufs_public_release. Squashed commit of the following: commit 5f7a981 Author: Valbona Kunkel <valbona.kunkel@noaa.gov> Date: Wed Jan 22 18:35:10 2020 -0500 Added to parameters list 4 new parameters commit 62a32e1 Author: Valbona Kunkel <valbona.kunkel@noaa.gov> Date: Tue Dec 17 14:38:28 2019 -0500 added Doxygen files commit af03053 Author: Valbona Kunkel <valbona.kunkel@noaa.gov> Date: Wed Oct 23 15:11:57 2019 -0400 corrected parameter list commit 47bdb2d Author: Valbona Kunkel <valbona.kunkel@noaa.gov> Date: Thu Oct 10 15:20:26 2019 -0400 add list description of parameters Co-authored-by: Fanglin Yang <fanglin.yang@noaa.gov> Co-authored-by: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: valbonakunkel-noaa <36248012+valbonakunkel-noaa@users.noreply.github.com>

sync dev/emc

TomBlack-NOAA added 11 commits October 30, 2019 12:11

Add new code for boundary blending and for getting BCs into GSI updates.

0916205

Changes for putting nrows_blend into input.nml.

34898ec

Merge branch 'dev/emc' into blend_DA

a76161c

Merge branch 'dev/emc' into blend_DA

235f511

Update branch with recent small changes.

92e823b

Merge branch 'dev/emc' into blend_DA

b50a2b3

Remove old versions of DA and blend files.

f8835a7

Clean up the regional module.

8abe8f0

Some more cleanup in the regional module.

7dfc7c7

Moved call to write_full_fields.

7b1288d

Merge branch 'dev/emc' into blend_DA

10f5bb9

This was referenced Mar 12, 2020

Regional BC blending and BCs into GSI ufs-community/ufs-weather-model#83

Merged

Regional BC blending and BCs into GSI NOAA-EMC/ufsatm#80

Merged

TomBlack-NOAA requested review from bensonr and junwang-noaa March 12, 2020 16:51

junwang-noaa reviewed Apr 3, 2020

View reviewed changes

bensonr suggested changes Apr 3, 2020

View reviewed changes

Modifications following code review.

c8d7dc7

junwang-noaa approved these changes Apr 6, 2020

View reviewed changes

DusanJovic-NOAA requested a review from bensonr April 7, 2020 13:20

bensonr approved these changes Apr 7, 2020

View reviewed changes

DusanJovic-NOAA merged commit 80ce8ce into NOAA-EMC:dev/emc Apr 8, 2020

TomBlack-NOAA deleted the blend_DA branch April 28, 2020 12:36

XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2022

Merge pull request NOAA-EMC#16 from JiliDong-NOAA/dev/emc

7d2b884

sync dev/emc

		! write(0,66811)is_0,ie_0,js_0,je_0
		66811 format(' allocated delp_BC(',i3,':',i3,',',i3,':',i3,')')

Conversation

TomBlack-NOAA commented Mar 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junwang-noaa Apr 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomBlack-NOAA commented Apr 3, 2020 via email

Uh oh!

TomBlack-NOAA commented Apr 3, 2020 via email

Uh oh!

bensonr left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bensonr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TomBlack-NOAA commented Mar 12, 2020 •

edited

Loading

junwang-noaa Apr 3, 2020 •

edited

Loading