Skip to content

Change FIXgdas to FIXgfs/gdas#932

Merged
CoryMartin-NOAA merged 1 commit into
developfrom
feature/remove_FIXgdas
Feb 21, 2024
Merged

Change FIXgdas to FIXgfs/gdas#932
CoryMartin-NOAA merged 1 commit into
developfrom
feature/remove_FIXgdas

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

Related to NOAA-EMC/global-workflow#2184

Needs to be merged in coordination with the workflow changes.

Removes the usage of FIXgdas and instead uses FIXgfs/gdas as the global-workflow is removing all FIX* variables except for FIXgfs

Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @CoryMartin-NOAA ! :)

@jiaruidong2017
Copy link
Copy Markdown
Collaborator

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

@jiaruidong2017 Thanks for noting this. I am making that change in global-workflow per feedback from @CoryMartin-NOAA NOAA-EMC/global-workflow#2184 (comment)

@jiaruidong2017
Copy link
Copy Markdown
Collaborator

@CoryMartin-NOAA There are one more FIXgdas in ush/python/pygfs/task/land_analysis.py, which need to be changed to FIXgfs.

Sorry, that is in the global-workflow.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 984ecbe into develop Feb 21, 2024
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/remove_FIXgdas branch February 21, 2024 15:28
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
Related to NOAA-EMC/global-workflow#2184

Needs to be merged in coordination with the workflow changes.

Removes the usage of FIXgdas and instead uses FIXgfs/gdas as the
global-workflow is removing all FIX* variables except for FIXgfs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants