Add spack-stack/1.6.0 support#873
Merged
Merged
Conversation
7 tasks
Contributor
|
All credit goes to @RussTreadon-NOAA for testing! Thanks @DavidHuber-NOAA for this PR. |
CoryMartin-NOAA
added
hera-GW-RT
CoryMartin-NOAA
previously approved these changes
Jan 25, 2024
emcbot
added
orion-GW-RT-Running
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
|
Automated Global-Workflow GDASApp Testing Results: |
emcbot
added
orion-GW-RT-Passed
Contributor
|
Orion test |
Contributor
|
Hercules test Install Examine log files for failed jobs. Find familiar error message Check loaded modules. See that This is done in the original @DavidHuber-NOAA , my modified We don't need |
RussTreadon-NOAA
previously approved these changes
Jan 25, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
hera.lua and orion.lua work as is. hercules.lua requires minor changes: (1) delete indicated loads, remove R2D2 line.
I'll approve once hercules.lua is updated.
DavidHuber-NOAA
dismissed stale reviews from RussTreadon-NOAA and CoryMartin-NOAA
via
a83936b
Contributor
|
Thank you @DavidHuber-NOAA for updating |
RussTreadon-NOAA
approved these changes
Jan 26, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Rebuilt DavidHuber-NOAA:feature/ss160 at a83936b on Hercules within g-w. Run ctests. All tests pass.
(gdasapp) hercules-login-3:/work/noaa/da/rtreadon/git/global_workflow/spackstack160_hercules/sorc/gdas.cd/build$ ctest -R test_gdasapp
Test project /work/noaa/da/rtreadon/git/global_workflow/spackstack160_hercules/sorc/gdas.cd/build
Start 1340: test_gdasapp_util_coding_norms
1/52 Test #1340: test_gdasapp_util_coding_norms ........................ Passed 4.28 sec
...
Start 1722: test_gdasapp_aero_gen_3dvar_yaml
52/52 Test #1722: test_gdasapp_aero_gen_3dvar_yaml ...................... Passed 0.29 sec
100% tests passed, 0 tests failed out of 52
Label Time Summary:
gdas-utils = 20.64 sec*proc (9 tests)
script = 20.64 sec*proc (9 tests)
Total Test time (real) = 1369.45 sec
Approve.
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
This upgrades GDASApp libraries to spack-stack version 1.6.0. Most notably, this upgrades the following libraries netcdf-fortran 4.6.0 -> 4.6.1 boost 1.78 -> 1.83.0 openblas 0.3.19 -> 0.3.24 sp 2.3.3 -> 2.5.0 Regression tests were run on Hera by @RussTreadon-NOAA and @CoryMartin-NOAA. --------- Co-authored-by: Cory Martin <cory.r.martin@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades GDASApp libraries to spack-stack version 1.6.0. Most notably, this upgrades the following libraries
netcdf-fortran 4.6.0 -> 4.6.1
boost 1.78 -> 1.83.0
openblas 0.3.19 -> 0.3.24
sp 2.3.3 -> 2.5.0
Regression tests were run on Hera by @RussTreadon-NOAA and @CoryMartin-NOAA.