Remove tests with R2D2 and anything referencing it

[AndrewEichmann-NOAA]

Removes soca ctests related to R2D2, associated data, and any lines in scripts, yamls, or other config files referencing it. SOCA ctests now run on obs prepped by the prep obs task.

Almost takes care of #815 as references are still present in global-workflow task config files.

logging.info has been replaced by print because logging hasn't been working

[AndrewEichmann-NOAA]

Can we remove it here:

GDASApp/.github/workflows/unittests.yaml

Line 18 in bd57012

- name: Install other dependencies

@CoryMartin-NOAA The whole - name: section, or just the three lines with "r2d2"?

[CoryMartin-NOAA]

Do we have any need for solo ? I don't think so, right?

[ShastriPaturi]

Will test with my in situ obs.
Approving it for now.

[guillaumevernieres]

Do we have any need for solo ? I don't think so, right?

no need for solo anymore @CoryMartin-NOAA .

[guillaumevernieres]

Can we remove it here:

GDASApp/.github/workflows/unittests.yaml

Line 18 in bd57012

- name: Install other dependencies

@CoryMartin-NOAA The whole - name: section, or just the three lines with "r2d2"?

The entire section @AndrewEichmann-NOAA ... I'm 99.3% sure we don't use solo outside of the r2d2 implementation ...

[AndrewEichmann-NOAA]

@CoryMartin-NOAA @guillaumevernieres ok, removed, let's see what happens

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Fri Jan  5 22:00:21 UTC 2024 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Jan  5 22:14:20 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Fri Jan  5 23:28:27 UTC 2024
Tests: 94% tests passed, 3 tests failed out of 52
	1688 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
	1705 - test_gdasapp_atm_jjob_ens_final (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/836/global-workflow/sorc/gdas.cd/build/log.ctest

[AndrewEichmann-NOAA]

test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY fails, test_gdasapp_atm_jjob_ens_run times out, and test_gdasapp_atm_jjob_ens_final fails - the vrfy is a known issue, what of the other two?

[guillaumevernieres]

test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY fails, test_gdasapp_atm_jjob_ens_run times out, and test_gdasapp_atm_jjob_ens_final fails - the vrfy is a known issue, what of the other two?

I suspect the test_gdasapp_atm_jjob_ens_final fails because of test_gdasapp_atm_jjob_ens_run and is probably unrelated to your changes ... So maybe we can ignore? @RussTreadon-NOAA , @CoryMartin-NOAA ?

[guillaumevernieres]

Looks good @AndrewEichmann-NOAA , do we have the dependencies sorted out properly in the g-w? If not it needs to be done asap, since merging this would break the cycling.

[RussTreadon-NOAA]

Yes, @guillaumevernieres, you are correct. test_gdasapp_atm_jjob_ens_final processes output from test_gdasapp_atm_jjob_ens_run. If the ens or var run job fails, the corresponding final job will fail. The ens_run job executes fv3jedi_letkf.x with 36 tasks. Depending on the system load, the queue wait time can exceed the ctest timeout limit.

[AndrewEichmann-NOAA]

@guillaumevernieres The changes to g-w depend on this PR and I don't think vice versa, so once this is in I can change g-w. I think it's just a matter of removing assignments from config files.

[guillaumevernieres]

Approving but lets not merge just quite yet until we have an understanding of how close we are with the corresponding g-w updates.
Thanks for doing this @AndrewEichmann-NOAA .