Use submodules rather than ecbuild_bundle git#811
Merged
Conversation
This reverts commit 99a6e88.
… into feature/submodule
CoryMartin-NOAA
requested review from
RussTreadon-NOAA,
aerorahul and
guillaumevernieres
Contributor
|
FYI: users need to load |
Contributor
|
Install GDASApp develop and feature/submodule on Hercules inside g-w. Run ctests for both installations. All tests pass in both installations except The The |
Contributor
|
FYI The update to global-workflow Tagging @CoryMartin-NOAA , @andytangborn , @guillaumevernieres , @AndrewEichmann-NOAA , and @DavidNew-NOAA |
Contributor
Author
|
@RussTreadon-NOAA the develop VRFY issue I think is being handled by @apchoiCMD . The feature branch issue looks familiar, is this something that got 'unresolved' by a merge commit? Looks like it may be a PYTHONPATH or cmake related problem? |
Contributor
Agreed regarding a path issue for |
Contributor
The vrfy jobs runs up to the The Note that eva and soca are in the above It seems the |
Collaborator
@RussTreadon-NOAA I am handling "vrfy" task on hera and it looks like resolved, so I will submit the PR along with checking it on Orion side, too. @CoryMartin-NOAA just wonder have you updated eva on Orion, too? |
Contributor
|
@apchoiCMD , if you have change(s) you would like me to test on Orion, let me know what to change and I'll give it a try. |
Contributor
|
Modify With this change the @apchoiCMD is working on a fix for this error. The above change to All |
Contributor
|
I have no more planned work on this PR apart from changes requested or suggested by reviewers. |
Contributor
|
Orion gw ctests |
Contributor
|
Hera gw ctests As mentioned before the Hecules, Hera, and Orion g-w snapshots contain the following local modifications
Note: As such, |
Contributor
|
global-workflow branch See g-w issue #2222 for details. |
RussTreadon-NOAA
approved these changes
Jan 16, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
feature/submodule installed on Hera, Hercules, and Orion within g-w develop. g-w ctest_gdasapp run on each machine. All tests pass except test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY . A fix for this ctest is under development.
Approve.
Contributor
Author
|
I will merge this later today! |
Collaborator
|
also resolves #835 |
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
This PR creates git submodules for each external JEDI library rather than using `ecbuild_bundle` to get the library source code through git. There is also a new set of scripts to automate the update process of the submodules (both an update and a git add, in separate scripts). Peppered through here are also some minor changes for CI testing that are needed due to this change + the global-workflow using submodules. --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov> Co-authored-by: RussTreadon-NOAA <russ.treadon@noaa.gov> Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates git submodules for each external JEDI library rather than using
ecbuild_bundleto get the library source code through git.There is also a new set of scripts to automate the update process of the submodules (both an update and a git add, in separate scripts).
Peppered through here are also some minor changes for CI testing that are needed due to this change + the global-workflow using submodules.