Skip to content

Add eva plotting to soca vrfy task#365

Merged
guillaumevernieres merged 9 commits into
developfrom
feature/eva-marine-test
Feb 28, 2023
Merged

Add eva plotting to soca vrfy task#365
guillaumevernieres merged 9 commits into
developfrom
feature/eva-marine-test

Conversation

@AndrewEichmann-NOAA
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA commented Feb 22, 2023 •
edited by guillaumevernieres
Loading

Adds eva plotting to vrfy task(#202), fixes bug in eva yaml generator (#362), and cleans up comments (#348)

Files changed:
scripts/exgdas_global_marine_analysis_vrfy.py
ush/eva/gen_eva_obs_yaml.py

@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Feb 22, 2023
@AndrewEichmann-NOAA AndrewEichmann-NOAA marked this pull request as ready for review February 22, 2023 20:26
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 22, 2023
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 22, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Wed Feb 22 20:33:19 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Wed Feb 22 21:36:25 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Wed Feb 22 21:49:50 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 43

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 22, 2023
@guillaumevernieres
Copy link
Copy Markdown
Contributor

guillaumevernieres commented Feb 22, 2023

First try for the automated CI ... ppfff, you're just showing off @AndrewEichmann-NOAA .

CoryMartin-NOAA
CoryMartin-NOAA reviewed Feb 23, 2023
View reviewed changes
Comment thread scripts/exgdas_global_marine_analysis_vrfy.py Outdated
Comment thread scripts/exgdas_global_marine_analysis_vrfy.py Outdated
Comment thread scripts/exgdas_global_marine_analysis_vrfy.py Outdated
Comment thread scripts/exgdas_global_marine_analysis_vrfy.py Outdated
Comment thread scripts/exgdas_global_marine_analysis_vrfy.py
@AndrewEichmann-NOAA
Copy link
Copy Markdown
Collaborator Author

AndrewEichmann-NOAA commented Feb 23, 2023 •
edited
Loading

I've addressed the subprocess calls as much as I think I can, but this requires a change to the jjob which first must be merged before merging this, but I want to get this approved before submitting the g-w PR

guillaumevernieres
guillaumevernieres requested changes Feb 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this PR until the j-job is updated

@AndrewEichmann-NOAA AndrewEichmann-NOAA mentioned this pull request Feb 23, 2023
Merged
6 tasks
@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed orion-GW-RT Queue for automated testing with global-workflow on Orion labels Feb 23, 2023
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 24, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Thu Feb 23 17:06:01 CST 2023 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Thu Feb 23 18:18:30 CST 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Thu Feb 23 19:05:06 CST 2023
Tests: 98% tests passed, 1 tests failed out of 43
	1364 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/365/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot removed the orion-GW-RT-Running Automated testing with global-workflow running on Orion label Feb 24, 2023
@emcbot emcbot added the orion-GW-RT-Failed Automated testing with global-workflow failed on Orion label Feb 24, 2023
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed orion-GW-RT-Failed Automated testing with global-workflow failed on Orion hera-GW-RT-Passed Automated testing with global-workflow successful on Hera labels Feb 25, 2023
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Feb 25, 2023
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 25, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Sat Feb 25 01:01:06 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Feb 25 01:43:17 UTC 2023
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Sat Feb 25 01:56:10 UTC 2023
Tests: 98% tests passed, 1 tests failed out of 43
	1377 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/365/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 25, 2023
@AndrewEichmann-NOAA AndrewEichmann-NOAA added hera-GW-RT Queue for automated testing with global-workflow on Hera and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera labels Feb 27, 2023
@AndrewEichmann-NOAA
Copy link
Copy Markdown
Collaborator Author

AndrewEichmann-NOAA commented Feb 27, 2023

restarted CI test on Hera now that NOAA-EMC/global-workflow#1331 is merged

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Feb 27, 2023
@emcbot
Copy link
Copy Markdown

emcbot commented Feb 27, 2023

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Feb 27 13:04:49 UTC 2023 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Feb 27 14:03:39 UTC 2023
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Feb 27 14:16:01 UTC 2023
Tests: 100% tests passed, 0 tests failed out of 43

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Feb 27, 2023
guillaumevernieres
guillaumevernieres approved these changes Feb 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@guillaumevernieres guillaumevernieres merged commit 4f05321 into develop Feb 28, 2023
@AndrewEichmann-NOAA AndrewEichmann-NOAA deleted the feature/eva-marine-test branch February 28, 2023 14:18
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@AndrewEichmann-NOAA
Add eva plotting to soca vrfy task (#365)
47a5609 
* add eva plotting to vrfy script

* fix bugs in yaml filename construction and mkdirs

* python coding norms

* remove superfluous and wrong env assignment

* made this less embarrasing

* python style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@guillaumevernieres guillaumevernieres guillaumevernieres approved these changes

@ADCollard ADCollard Awaiting requested review from ADCollard

Assignees

No one assigned

Labels

hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ioda change in diag file layout might break eva yaml generator Miss-guiding comment in vrfy j-job Generate marine DA plots using EVA in the GDASApp

4 participants

@AndrewEichmann-NOAA @emcbot @guillaumevernieres @CoryMartin-NOAA