Feature/soca remove cdate

[AndrewEichmann-NOAA]

Removes references to CDATE as non-local variable; in a couple of instances it is assigned locally to ${PDY}${cyc}. Addresses issue #237

Tested with ctests+ in build/test (ie, not just for soca)

Depends on the merging of global-workflow PR NOAA-EMC/global-workflow#1191 to work for g-w, but should work for soca alone

Files changed:
parm/soca/obs/config/adt_j3.yaml
parm/soca/obs/config/icec_emc.yaml
parm/soca/obs/config/salt_profile_fnmoc.yaml
parm/soca/obs/config/sss_smap.yaml
parm/soca/obs/config/sst_noaa19_l3u.yaml
parm/soca/obs/config/sst_noaa19_l3u_so025.yaml
scripts/exgdas_global_marine_analysis_prep.py
test/soca/gw/config.base
test/soca/gw/runtime_vars.sh
test/soca/runtime_vars.sh
ush/ufsda/misc_utils.py

[guillaumevernieres]

@AndrewEichmann-NOAA , the CI won't work until your gw PR is merged.

[emcbot]

Automated GDASApp Testing Results:
Machine: hera

Start: Fri Dec 16 21:45:18 UTC 2022 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Dec 16 22:26:57 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Dec 16 22:28:58 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 27

[emcbot]

Automated GDASApp Testing Results:
Machine: orion

Start: Fri Dec 16 15:47:22 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Dec 16 16:44:55 CST 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Dec 16 16:58:05 CST 2022
Tests: 100% tests passed, 0 tests failed out of 27

[guillaumevernieres]

The CI worked @AndrewEichmann-NOAA but you need to address @CoryMartin-NOAA 's comment about the missing $RUN as a prefix. Looks good otherwise.

[guillaumevernieres]

I'm taking the liberty to push to your branch @AndrewEichmann-NOAA ... Needs a few minor updates.

[RussTreadon-NOAA]

Changes look straightforward. Approve pending successful GW-RT on Hera and Orion.

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Tue Dec 20 18:04:08 UTC 2022 on hfe07
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Dec 20 19:00:59 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Dec 20 19:09:10 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 35

[emcbot]

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Tue Dec 20 12:03:13 CST 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Tue Dec 20 13:16:37 CST 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Tue Dec 20 13:32:38 CST 2022
Tests: 100% tests passed, 0 tests failed out of 35

[AndrewEichmann-NOAA]

For clarification, is this the comment in NOAA-EMC/global-workflow#1191 that needs to be addressed?

CoryMartin-NOAA (NOAA-EMC/global-workflow#1191 (comment))
I think @aerorahul wants instead this to be ${RUN}ocnanal_${cyc} per a conversation he and I had yesterday afternoon

Member
@aerorahul aerorahul (NOAA-EMC/global-workflow#1191 (comment))
Yes. Thanks @CoryMartin-NOAA.
${PDY} is not available at this time, so the issue is correct on that, that ${CDATE} should become ${cyc}.

I also realized yesterday, that our run directories will get clobbered when gdas and gfs cycles start. To distinguish between those, it is best to prepend ocnanal with a ${RUN}.

${RUN} is set upstream of the job in the ecflow/rocoto job-card. EMC internally translates that to ${CDUMP}, which is also not available at this point in the j-job.

[guillaumevernieres]

I forgot if I added RUN yesterday @AndrewEichmann-NOAA , you might need to issue a bugfix.

[aerorahul]

@AndrewEichmann-NOAA @guillaumevernieres
I don't think so. This was merged yesterday and it looks right in develop.

export DATA=${DATA:-${DATAROOT}/${RUN}ocnanal_${cyc}}

I think the comment has been addressed. Thank you for doing so.