Remove duplicate copying of ensemble members from marine recenter task#1614
Merged
Conversation
shlyaeva
added
hera-GW-RT
emcbot
added
hercules-GW-RT-Running
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hercules-GW-RT-Passed
|
Automated GW-GDASApp Testing Results: |
emcbot
added
hera-GW-RT-Passed
AndrewEichmann-NOAA
approved these changes
Apr 14, 2025
Contributor
|
While you might need new 👓 @AndrewEichmann-NOAA , I, on the other hand probably need a new 🧠 ... I was convinced we merged this last week. |
guillaumevernieres
approved these changes
Apr 14, 2025
jspsl
pushed a commit
to NOAA-PSL/GDASApp
that referenced
this pull request
Apr 30, 2025
NOAA-EMC#1614) # Description In NOAA-EMC#1479 I introduced a duplicate copy of ensemble members to marine recentering task by mistake. This PR removes that. I didn't test this as thoroughly as I normally would. Below is what I ran to test (for both of the low-res tests I made sure that both rundir and comdir were completely wiped out before I started the tests): - all tests in C48mx500_hybAOWCDA up to and including ocnanalecen -- tests passed - all tests in C48mx500_hybAOWCDA up to and including ocnanalecen except for the letkf one (to mimic retro runs) -- tests passed - introduced this change in my high-res 30-member ensemble experiment that runs LETKF -- task completed successfully, 33 min instead of 38 min for the previous cycle. # Issues Resolves NOAA-EMC#1613 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov>
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
#1614) # Description In #1479 I introduced a duplicate copy of ensemble members to marine recentering task by mistake. This PR removes that. I didn't test this as thoroughly as I normally would. Below is what I ran to test (for both of the low-res tests I made sure that both rundir and comdir were completely wiped out before I started the tests): - all tests in C48mx500_hybAOWCDA up to and including ocnanalecen -- tests passed - all tests in C48mx500_hybAOWCDA up to and including ocnanalecen except for the letkf one (to mimic retro runs) -- tests passed - introduced this change in my high-res 30-member ensemble experiment that runs LETKF -- task completed successfully, 33 min instead of 38 min for the previous cycle. # Issues Resolves #1613 # Automated CI tests to run in Global Workflow <!-- Which Global Workflow CI tests are required to adequately test this PR? --> - [ ] atm_jjob <!-- JEDI atm single cycle DA !--> - [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !--> - [ ] C96C48_hybatmaerosnowDA <!-- JEDI aero/snow cycled DA !--> - [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> - [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !--> Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #1479 I introduced a duplicate copy of ensemble members to marine recentering task by mistake. This PR removes that.
I didn't test this as thoroughly as I normally would. Below is what I ran to test (for both of the low-res tests I made sure that both rundir and comdir were completely wiped out before I started the tests):
Issues
Resolves #1613
Automated CI tests to run in Global Workflow