Skip to content

Bugfix ocean ensemble recentering #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumevernieres merged 2 commits into from
Mar 19, 2025
Merged

Bugfix ocean ensemble recentering #1558

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
326408b
Bugfix ocean ensemble recentering
Mar 18, 2025
13ccf42
Merge branch 'develop' into bugfix/ocn_recenter
shlyaeva Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions utils/soca/gdas_ens_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ namespace gdasapp {
soca::Increment recenteringIncr(geomOut, postProcIncr.socaIncrVar_, postProcIncr.dt_);
recenteringIncr.diff(determTraj, ensMeanTraj);
postProcIncr.setToZero(recenteringIncr);
oops::Log::info() << "recentering incr: " << recenteringIncr << std::endl;

// Check if we're only re-centering the ensemble fcst around the det.
bool recenterOnly = fullConfig.getBool("recentering around deterministic", false);
Expand All @@ -156,16 +157,12 @@ namespace gdasapp {
oops::Log::info() << "Only recentering " << std::endl;
int result = 0;
for (size_t i = 0; i < postProcIncr.ensSize_; ++i) {
// make a copy of the ens. member
soca::Increment incr(ensMembers[i]);

// Add the recentering increment
incr += recenteringIncr;
oops::Log::info() << "recentered incr " << i << ":" << incr << std::endl;
// make a copy of the recentering increment
soca::Increment incr(recenteringIncr);

// Append the vertical geometry (for MOM6 IAU)
soca::Increment mom6_incr = postProcIncr.appendLayer(incr);
oops::Log::info() << "incr " << i << ":" << mom6_incr << std::endl;
oops::Log::info() << "recentering incr " << i << ":" << mom6_incr << std::endl;

// Set variables to zero if specified in the configuration
postProcIncr.setToZero(incr);
Expand Down