-
Notifications
You must be signed in to change notification settings - Fork 50
Incorporate multi-cycle concatination and separation of variables in post-BUFR observations #1504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5b93376
like athena from zeus's forehead
AndrewEichmann-NOAA 18054ef
Merge branch 'develop' into feature/insitu-concat
AndrewEichmann-NOAA 4c987cb
remove comments
AndrewEichmann-NOAA 45416ea
style points
AndrewEichmann-NOAA 92e8e6d
style points
AndrewEichmann-NOAA 6f5dbf7
corrections to configs, filename aligment
AndrewEichmann-NOAA 055a80f
Merge branch 'develop' into feature/insitu-concat
guillaumevernieres 3876928
coordination of input and output filenames
AndrewEichmann-NOAA 2efb0c3
Merge branch 'feature/insitu-concat' of https://github.com/NOAA-EMC/G…
AndrewEichmann-NOAA 89a056e
Merge branch 'develop' into feature/insitu-concat
AndrewEichmann-NOAA 8975174
deleting commented-out bits
AndrewEichmann-NOAA fe2669d
removed comments
AndrewEichmann-NOAA a26fb49
Merge branch 'develop' into feature/insitu-concat
AndrewEichmann-NOAA 2ddd8bf
Merge branch 'develop' into feature/insitu-concat
AndrewEichmann-NOAA e628903
remove old argo obs space
AndrewEichmann-NOAA 1cf85fb
Merge branch 'feature/insitu-concat' of https://github.com/NOAA-EMC/G…
AndrewEichmann-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
parm/ioda/bufr2ioda/bufr2ioda_insitu_salt_profile_argo.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| cycle_datetime: '{{ current_cycle | to_YMDH }}' | ||
| cycle_type: '{{ RUN }}' | ||
| data_description: 6-hrly in situ ARGO profiles | ||
| data_format: subpfl | ||
| data_provider: U.S. NOAA | ||
| data_type: argo | ||
| dump_directory: '{{ DMPDIR }}' | ||
| ioda_directory: '{{ COM_OBS }}' | ||
| source: NCEP data tank | ||
| subsets: SUBPFL | ||
| ocean_basin: '{{ OCEAN_BASIN_FILE }}' |
11 changes: 11 additions & 0 deletions
11
parm/ioda/bufr2ioda/bufr2ioda_insitu_temp_profile_argo.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| cycle_datetime: '{{ current_cycle | to_YMDH }}' | ||
| cycle_type: '{{ RUN }}' | ||
| data_description: 6-hrly in situ ARGO profiles | ||
| data_format: subpfl | ||
| data_provider: U.S. NOAA | ||
| data_type: argo | ||
| dump_directory: '{{ DMPDIR }}' | ||
| ioda_directory: '{{ COM_OBS }}' | ||
| source: NCEP data tank | ||
| subsets: SUBPFL | ||
| ocean_basin: '{{ OCEAN_BASIN_FILE }}' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,179 @@ | ||
| obs space: | ||
| name: insitu_salt_profile_argo | ||
| obsdatain: | ||
| engine: | ||
| type: H5File | ||
| obsfile: ${DATA}/obs/${OPREFIX}insitu_salt_profile_argo.${PDY}${cyc}.nc4 | ||
| obsgrouping: | ||
| group variables: [latitude, longitude, dateTime] | ||
| sort variable: depth | ||
| sort group: MetaData | ||
| sort order: ascending | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: ${DATA}/diags/insitu_salt_profile_argo.${PDY}${cyc}.nc4 | ||
| simulated variables: [salinity] | ||
| observed variables: [salinity] | ||
| io pool: | ||
| max pool size: 1 | ||
| obs operator: | ||
| name: VertInterp | ||
| observation alias file: ./obsop_name_map.yaml | ||
| vertical coordinate: sea_water_depth | ||
| observation vertical coordinate: depth | ||
| interpolation method: linear | ||
| obs error: | ||
| covariance model: diagonal | ||
|
|
||
| #------------------------------------------------------------------------------- | ||
| # START OF OBS FILTERS (work done by Kriti Bhargava) | ||
| # The QC filters used here are based on the document by IODE that can be found at | ||
| # https://cdn.ioos.noaa.gov/media/2017/12/recommendations_in_situ_data_real_time_qc.pdf | ||
| #------------------------------------------------------------------------------- | ||
| obs filters: | ||
|
|
||
| # land check | ||
| - filter: Domain Check | ||
| where: | ||
| - variable: {name: GeoVaLs/sea_area_fraction} | ||
| minvalue: 0.5 | ||
|
|
||
|
|
||
| #------------------------------------------------------------------------------- | ||
| ## Filters for S: | ||
| #------------------------------------------------------------------------------- | ||
| #----------------------------------------------------------------------------- | ||
| ### Global range test | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 41.0 | ||
|
|
||
| #----------------------------------------------------------------------------- | ||
| ### Regional range test | ||
| #----------------------------------------------------------------------------- | ||
| #### Red Sea | ||
| #----------------------------------------------------------------------------- | ||
| #### | ||
| #### the document linked here describes Red sea as the are between 10N, 40E; | ||
| #### 20N, 50E; 30N, 30E; 10N, 40E. But that would also include Gulf of Aden. | ||
| #### A more reasonable choice seemed to be a box that extends from 10 N to | ||
| #### 30 N and 30 E to 45 East . | ||
|
|
||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 41.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 10 | ||
| maxvalue: 30 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 30 | ||
| maxvalue: 45 | ||
|
|
||
| #### Mediterranean Sea | ||
| #----------------------------------------------------------------------------- | ||
| ##### Area 1/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 30 | ||
| maxvalue: 40 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -6 | ||
| maxvalue: 40 | ||
| ##### Area 2/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 40 | ||
| maxvalue: 41.5 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 20 | ||
| maxvalue: 30 | ||
| ##### Area 3/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 40 | ||
| maxvalue: 46 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 0 | ||
| maxvalue: 20 | ||
|
|
||
|
|
||
| #### Northwestern shelves | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 0.0 | ||
| maxvalue: 37.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 50 | ||
| maxvalue: 60 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -20 | ||
| maxvalue: 10 | ||
|
|
||
| #### Southwestern shelves | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 0.0 | ||
| maxvalue: 38 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 25 | ||
| maxvalue: 50 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -30 | ||
| maxvalue: 0 | ||
|
|
||
| #### Arctic Sea | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: salinity}] | ||
| minvalue: 2.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 60 | ||
|
|
||
| - filter: Background Check | ||
| filter variables: [{name: salinity}] | ||
| threshold: 5.0 | ||
| absolute threshold: 5.0 | ||
|
|
||
| obs localizations: | ||
| - localization method: Rossby | ||
| base value: 100.0e3 | ||
| rossby mult: 1.0 | ||
| min grid mult: 2.0 | ||
| min value: 200.0e3 | ||
| max value: 900.0e3 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| obs space: | ||
| name: insitu_temp_profile_argo | ||
| obsdatain: | ||
| engine: | ||
| type: H5File | ||
| obsfile: ${DATA}/obs/${OPREFIX}insitu_temp_profile_argo.${PDY}${cyc}.nc4 | ||
| obsgrouping: | ||
| group variables: [latitude, longitude, dateTime] | ||
| sort variable: depth | ||
| sort group: MetaData | ||
| sort order: ascending | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: ${DATA}/diags/insitu_temp_profile_argo.${PDY}${cyc}.nc4 | ||
| simulated variables: [waterTemperature] | ||
| observed variables: [waterTemperature] | ||
| io pool: | ||
| max pool size: 1 | ||
| obs operator: | ||
| name: InsituTemperature | ||
| obs error: | ||
| covariance model: diagonal | ||
|
|
||
| #------------------------------------------------------------------------------- | ||
| # START OF OBS FILTERS (work done by Kriti Bhargava) | ||
| # The QC filters used here are based on the document by IODE that can be found at | ||
| # https://cdn.ioos.noaa.gov/media/2017/12/recommendations_in_situ_data_real_time_qc.pdf | ||
| #------------------------------------------------------------------------------- | ||
| obs filters: | ||
|
|
||
| # land check | ||
| - filter: Domain Check | ||
| where: | ||
| - variable: {name: GeoVaLs/sea_area_fraction} | ||
| minvalue: 0.5 | ||
|
|
||
| #------------------------------------------------------------------------------- | ||
| ## Filters for T: | ||
| #------------------------------------------------------------------------------- | ||
| #------------------------------------------------------------------------------- | ||
| ### Global range test | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: -2.5 | ||
| maxvalue: 40.0 | ||
|
|
||
| #----------------------------------------------------------------------------- | ||
| ### Regional range tests | ||
| #----------------------------------------------------------------------------- | ||
|
|
||
| #### Red Sea | ||
| #----------------------------------------------------------------------------- | ||
| #### | ||
| #### the document linked here describes Red sea as the are between 10N, 40E; | ||
| #### 20N, 50E; 30N, 30E; 10N, 40E. But that would also include Gulf of Aden. | ||
| #### A more reasonable choice seemed to be a box that extends from 10 N to | ||
| #### 30 N and 30 E to 45 East . | ||
|
|
||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: 21.7 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 10 | ||
| maxvalue: 30 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 30 | ||
| maxvalue: 45 | ||
|
|
||
| #### Mediterranean Sea | ||
| #----------------------------------------------------------------------------- | ||
| ##### Area 1/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: 10.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 30 | ||
| maxvalue: 40 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -6 | ||
| maxvalue: 40 | ||
| ##### Area 2/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: 10.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 40 | ||
| maxvalue: 41.5 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 20 | ||
| maxvalue: 30 | ||
| ##### Area 3/3 for Mediterranean Sea | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: 10.0 | ||
| maxvalue: 40.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 40 | ||
| maxvalue: 46 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: 0 | ||
| maxvalue: 20 | ||
|
|
||
| #### Northwestern shelves | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: -2.0 | ||
| maxvalue: 24.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 50 | ||
| maxvalue: 60 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -20 | ||
| maxvalue: 10 | ||
| #### Southwestern shelves | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: -2.0 | ||
| maxvalue: 30 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 25 | ||
| maxvalue: 50 | ||
| - variable: | ||
| name: MetaData/longitude | ||
| minvalue: -30 | ||
| maxvalue: 0 | ||
|
|
||
| #### Arctic Sea | ||
| #----------------------------------------------------------------------------- | ||
| - filter: Bounds Check | ||
| filter variables: [{name: waterTemperature}] | ||
| minvalue: -1.92 | ||
| maxvalue: 25.0 | ||
| where: | ||
| - variable: | ||
| name: MetaData/latitude | ||
| minvalue: 60 | ||
|
|
||
| - filter: Background Check | ||
| filter variables: [{name: waterTemperature}] | ||
| threshold: 5.0 | ||
| absolute threshold: 5.0 | ||
|
|
||
| obs localizations: | ||
| - localization method: Rossby | ||
| base value: 100.0e3 | ||
| rossby mult: 1.0 | ||
| min grid mult: 2.0 | ||
| min value: 200.0e3 | ||
| max value: 900.0e3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.