Skip to content

Bugfix for ensemble recenter + add a test #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumevernieres merged 1 commit into from
Feb 5, 2025
Merged

Bugfix for ensemble recenter + add a test #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parm/soca/berror/soca_ensrecenter.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,5 +60,5 @@ output increment:
date: '{{ MARINE_WINDOW_END_ISO }}'
exp: trash
type: incr
output file: 'ocn.recenter.incr.%mem%.nc'
output file: 'recenter.incr.%mem%.nc'
pattern: '%mem%'
4 changes: 4 additions & 0 deletions test/gw-ci/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ function(add_task task_name test_prefix is_full_cycle HALF_CYCLE FULL_CYCLE pslo
elseif("${task_name}" STREQUAL "gdas_marineanlletkf")
list(APPEND TEST_DEPENDS "${test_prefix}_enkfgdas_fcst_${HALF_CYCLE}")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_prepoceanobs_${FULL_CYCLE}")
elseif("${task_name}" STREQUAL "gdas_ocnanalecen")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_marineanlvar_${FULL_CYCLE}")
list(APPEND TEST_DEPENDS "${test_prefix}_gdas_marineanlletkf_${FULL_CYCLE}")
else()
list(APPEND TEST_DEPENDS "${test_prefix}")
endif()
Expand Down Expand Up @@ -394,6 +397,7 @@ if (WORKFLOW_TESTS)
"gdas_marinebmat"
"gdas_marineanlinit"
"gdas_marineanlvar"
"gdas_ocnanalecen"
"gdas_marineanlchkpt"
"gdas_marineanlfinal"
)
Expand Down
2 changes: 1 addition & 1 deletion utils/soca/gdas_ens_handler.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ namespace gdasapp {
postProcIncr.setToZero(incr);

// Save the increments used to initialize the ensemble forecast
result = postProcIncr.save(mom6_incr, i+1);
result = postProcIncr.save(mom6_incr, i+1, {"ocn"});
}
return result;
}
Expand Down