Make sure gfs_* DA jobs are not regression tests#1390
Merged
Conversation
DavidNew-NOAA
requested review from
CoryMartin-NOAA,
RussTreadon-NOAA and
danholdaway
RussTreadon-NOAA
approved these changes
Nov 27, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Did not test but @DavidNew-NOAA did and found that all regression tests pass.
We need the changes in this PR to move g-w PR #3120 forward.
Approve.
22 tasks
DavidNew-NOAA
added a commit
that referenced
this pull request
Jan 16, 2026
This PR addresses the bug @RussTreadon-NOAA found that ```gfs_atmanlvar``` was being run as a regression test and using the same test reference as ```gdas_atmanlvar``` in GW PR [#3120](NOAA-EMC/global-workflow#3120). See NOAA-EMC/global-workflow#3120 (comment) I've moved all activation of testing mode in JCB out of the JCB base YAMLs and into the JCB algorithm YAMLs. I test the ```RUN``` variables to make sure it's not equal to ```gfs```. I re-ran all the regression tests, and they all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the bug @RussTreadon-NOAA found that
gfs_atmanlvarwas being run as a regression test and using the same test reference asgdas_atmanlvarin GW PR #3120.See NOAA-EMC/global-workflow#3120 (comment)
I've moved all activation of testing mode in JCB out of the JCB base YAMLs and into the JCB algorithm YAMLs. I test the
RUNvariables to make sure it's not equal togfs.I re-ran all the regression tests, and they all passed.