Update hercules module file to spack-stack 1.7#1330
Merged
Conversation
guillaumevernieres
requested review from
CoryMartin-NOAA,
DavidNew-NOAA,
RussTreadon-NOAA and
danholdaway
Contributor
|
did the github actions default image change again? all of the actions are failing... |
Contributor
Something changed on their side. Do we need to change something on our side? |
Contributor
|
@guillaumevernieres does this work on hercules? |
Contributor
Author
@CoryMartin-NOAA , a few things were failing, I forgot exactly what but it wasn't related to the switch to 1.7 as far as I remember. |
CoryMartin-NOAA
approved these changes
Oct 15, 2024
Contributor
|
Hercules ctest |
Contributor
|
PR #1312 replaced
These GDASApp changes require corresponding g-w changes. @DavidNew-NOAA has these changes in g-w PR #2992. I built @DavidNew-NOAA notes that ctests will fail until g-w PR #2992 is merged into g-w The remaining |
apchoiCMD
requested changes
Oct 15, 2024
Collaborator
apchoiCMD
left a comment
apchoiCMD
left a comment
There was a problem hiding this comment.
Please fix the marine DA that you found out-
Contributor
Author
yes sir! 🫡 |
Contributor
Author
|
OK, after a bit of confusion with all the parallel development that is going on with different combinations of dozens of repositories, this PR should ignore the marine DA testing. The marine DA will be broken until NOAA-EMC/global-workflow#2978 is merged. From @RussTreadon-NOAA 's log, : the rendered background error:
covariance model: SABER
saber central block:
saber block name: diffusion
read:
groups:
- variables: [tocn, socn, ssh]
horizontal:
filepath: ./staticb/hz_ocean
vertical:
levels: {{MOM6_LEVS}} # <------- BAD!!!!!
filepath: ./staticb/vt_ocean |
Contributor
Author
Sorry @apchoiCMD , we'll have to wait for upstream PR's to be merged before the marine DA is fixed. |
danholdaway
approved these changes
Oct 16, 2024
apchoiCMD
approved these changes
Oct 16, 2024
DavidNew-NOAA
pushed a commit
that referenced
this pull request
Jan 16, 2026
In case somebody feels like testing this ... Draft because it's untested and still building. - fixes #1329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case somebody feels like testing this ...
Draft because it's untested and still building.