Skip to content

Additional support for surface pressure observations#110

Merged
CoryMartin-NOAA merged 4 commits intodevelopfrom
feature/sfc_ps
Aug 17, 2022
Merged

Additional support for surface pressure observations#110
CoryMartin-NOAA merged 4 commits intodevelopfrom
feature/sfc_ps

Conversation

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor

This PR does 3 main things:

  • Adds official support for surface pressure observations in hofx/var applications (note: results may not yet be right using obs in R2D2 at this time due to a bug in combining t/ps obs, see previously merged Fix for ncdiag converter for conv surface type JCSDA-internal/ioda-converters#953)
  • Adds a test file for geovals for other surface ob types
  • Adds additional plot types to the example EVA generation template
  • Update the paths to the input files for running UFO with GSI geovals

@CoryMartin-NOAA
Copy link
Copy Markdown
Contributor Author

"(note: results may not yet be right using obs in R2D2 at this time ...)" this has been resolved on Orion. The R2D2 database there now should have corrected combined obs. Will wait to copy to Hera once fully validated.

Copy link
Copy Markdown
Collaborator

@nicholasesposito nicholasesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All makes sense to me. Thanks Cory

@@ -1,14 +1,14 @@
obs space:
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a difference in purposes between the sfc.yaml in the config directory and the sfc.yaml in the testing directory?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the intention was for config/ to be the 'production' ready files, as in they have been tested and work, whereas testing/ might not yet work properly but are there as examples/a work in progress. But I'm open to changing/removing that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input formats of the YAMLs in the UFO tests are different than the 'real' executables, so that was why I split them into separate directories.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 171f498 into develop Aug 17, 2022
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/sfc_ps branch August 17, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants