Skip to content

The DA only uses the gdas bkg ... fixing again ...#1079

Merged
guillaumevernieres merged 3 commits into
developfrom
bugfix/gdas-NOT-RUN
Apr 29, 2024
Merged

The DA only uses the gdas bkg ... fixing again ...#1079
guillaumevernieres merged 3 commits into
developfrom
bugfix/gdas-NOT-RUN

Conversation

@guillaumevernieres
Copy link
Copy Markdown
Contributor

@guillaumevernieres guillaumevernieres commented Apr 29, 2024

@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 29, 2024
CatherineThomas-NOAA
CatherineThomas-NOAA previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending successful testing.

@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera and removed hera-GW-RT Queue for automated testing with global-workflow on Hera labels Apr 29, 2024
@JessicaMeixner-NOAA
Copy link
Copy Markdown
Collaborator

JessicaMeixner-NOAA commented Apr 29, 2024

I'll point to this branch and restart the C384 tests i was running

@emcbot emcbot added orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 29, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Apr 29 15:38:26 UTC 2024 on hfe11
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 29 16:25:57 UTC 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Apr 29 16:59:47 UTC 2024
Tests: 98% tests passed, 1 tests failed out of 45
	1758 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN (Failed)
Tests: see output at /scratch1/NCEPDEV/da/Cory.R.Martin/CI/GDASApp/workflow/PR/1079/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added hera-GW-RT-Failed Automated testing with global-workflow failed on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 29, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Apr 29 10:36:10 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 29 11:38:22 CDT 2024
---------------------------------------------------
Tests:                                  *Failed*
Tests: Failed at Mon Apr 29 12:08:47 CDT 2024
Tests: 98% tests passed, 1 tests failed out of 45
	1759 - test_gdasapp_soca_JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN (Failed)
Tests: see output at /work2/noaa/stmp/cmartin/CI/GDASApp/workflow/PR/1079/global-workflow/sorc/gdas.cd/build/log.ctest

@emcbot emcbot added orion-GW-RT-Failed Automated testing with global-workflow failed on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 29, 2024
@guillaumevernieres guillaumevernieres added hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion and removed hera-GW-RT-Failed Automated testing with global-workflow failed on Hera orion-GW-RT-Failed Automated testing with global-workflow failed on Orion labels Apr 29, 2024
@emcbot emcbot added hera-GW-RT-Running Automated testing with global-workflow running on Hera orion-GW-RT-Running Automated testing with global-workflow running on Orion and removed hera-GW-RT Queue for automated testing with global-workflow on Hera orion-GW-RT Queue for automated testing with global-workflow on Orion labels Apr 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 29, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: hera

Start: Mon Apr 29 17:30:34 UTC 2024 on hfe04
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 29 18:21:26 UTC 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Apr 29 18:51:15 UTC 2024
Tests: 100% tests passed, 0 tests failed out of 45

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Apr 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 29, 2024

Automated Global-Workflow GDASApp Testing Results:
Machine: orion

Start: Mon Apr 29 12:31:30 CDT 2024 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Mon Apr 29 13:32:19 CDT 2024
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Mon Apr 29 13:55:41 CDT 2024
Tests: 100% tests passed, 0 tests failed out of 45

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Apr 29, 2024
AndrewEichmann-NOAA
AndrewEichmann-NOAA previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks even better

AndrewEichmann-NOAA
AndrewEichmann-NOAA approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@AndrewEichmann-NOAA AndrewEichmann-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still looks good

@guillaumevernieres guillaumevernieres merged commit 69ef3fe into develop Apr 29, 2024
@guillaumevernieres guillaumevernieres deleted the bugfix/gdas-NOT-RUN branch April 29, 2024 19:48
danholdaway added a commit that referenced this pull request May 2, 2024
@danholdaway
Merge branch 'develop' into feature/use_jcb_atm
6ef814f 
* develop:
  Visualize stats in simple html document (#1089)
  Time series of csv stats (#1086)
  Use the gdas bkg for the static B (#1084)
  Add module files to compile on AWS (#1082)
  The DA only uses the gdas bkg ... fixing again ... (#1079)
  Using ioda util to convert the datetime in AMSR2 converter (#1077)
  Add modulefile for Dogwood/Cactus (#1073)
  Addition of a switch for the cycling type (#1072)
  Added YAML, JSON, python files for assimilating VIIRS satwinds (#1055)
  No mpi for the ascii stats (#1070)
DavidNew-NOAA pushed a commit that referenced this pull request Jan 16, 2026
@guillaumevernieres
The DA only uses the gdas bkg ... fixing again ... (#1079)
cbfd743 
- fixes #1078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewEichmann-NOAA AndrewEichmann-NOAA AndrewEichmann-NOAA approved these changes

@JessicaMeixner-NOAA JessicaMeixner-NOAA Awaiting requested review from JessicaMeixner-NOAA

@CatherineThomas-NOAA CatherineThomas-NOAA Awaiting requested review from CatherineThomas-NOAA

Assignees

No one assigned

Labels

hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The gfs is not used as background (yet)

5 participants

@guillaumevernieres @JessicaMeixner-NOAA @emcbot @AndrewEichmann-NOAA @CatherineThomas-NOAA