Skip to content

Using ioda util to convert the datetime in AMSR2 converter #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumevernieres merged 3 commits into from
Apr 26, 2024
Merged

Using ioda util to convert the datetime in AMSR2 converter #1077

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd58ae6
use ioda util for datetime
apchoiCMD Apr 26, 2024
06dd172
c-norm
apchoiCMD Apr 26, 2024
61d42f0
Merge branch 'develop' into bugfix/amsr2-datetime
guillaumevernieres Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions utils/obsproc/IcecAmsr2Ioda.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@

#include <Eigen/Dense> // NOLINT

#include "ioda/../../../../core/IodaUtils.h"
#include "ioda/Group.h"
#include "ioda/ObsGroup.h"

#include "oops/util/dateFunctions.h"

#include "NetCDFToIodaConverter.h"
Expand Down Expand Up @@ -83,30 +85,42 @@ namespace gdasapp {
int minute = oneTmpdateTimeVal[i+4];
int second = static_cast<int>(oneTmpdateTimeVal[i+5]);

// Replace Fillvalue -9999 to 0 to avoid crash in dateToJulian
// Avoid crash util in ioda::convertDtimeToTimeOffsets
if (year == -9999 || month == -9999 || day == -9999 ||
hour == -9999 || minute == -9999 || second == -9999) {
year = month = day = hour = minute = second = 0;
}

// Convert a date to Julian date
uint64_t julianDate = util::datefunctions::dateToJulian(year, month, day);

// Subtract Julian day from January 1, 1970 (convert to epoch)
int daysSinceEpoch = julianDate - 2440588;

// Calculate seconds only from HHMMSS
int secondsOffset = util::datefunctions::hmsToSeconds(hour, minute, second);

iodaVars.datetime_(index) = static_cast<int64_t>(daysSinceEpoch*86400.0f) + secondsOffset;
// Construct iso8601 string format for each dateTime
std::stringstream ss;
ss << std::setfill('0')
<< std::setw(4) << year << '-'
<< std::setw(2) << month << '-'
<< std::setw(2) << day << 'T'
<< std::setw(2) << hour << ':'
<< std::setw(2) << minute << ':'
<< std::setw(2) << second << 'Z';
std::string formattedDateTime = ss.str();
util::DateTime dateTime(formattedDateTime);

// Set epoch time for AMSR2_ICEC
util::DateTime epochDtime("1970-01-01T00:00:00Z");

// Convert Obs DateTime objects to epoch time offsets in seconds
// 0000-00-00T00:00:00Z will be converterd to negative seconds
int64_t timeOffsets
= ioda::convertDtimeToTimeOffsets(epochDtime, {dateTime})[0];

// Update datetime Eigen Arrays
iodaVars.datetime_(index) = timeOffsets;
index++;
}

// Update non-optional Eigen arrays
for (int i = 0; i < iodaVars.location_; i++) {
iodaVars.longitude_(i) = oneDimLonVal[i];
iodaVars.latitude_(i) = oneDimLatVal[i];
iodaVars.obsVal_(i) = static_cast<float>(oneDimObsVal[i]*0.01f);
iodaVars.obsVal_(i) = static_cast<float>(oneDimObsVal[i]*0.01);
iodaVars.obsError_(i) = 0.1; // Do something for obs error
iodaVars.preQc_(i) = oneDimFlagsVal[i];
// Store optional metadata, set ocean basins to -999 for now
Expand Down