Skip to content

Modify send_data_3d in diag_manager.F90 to move SELECT TYPE blocks out of triple do loops#8

Merged
MinsukJi-NOAA merged 14 commits into
NOAA-EMC:fms_mixedmodefrom
MinsukJi-NOAA:feature/mji_mixedmode
Nov 3, 2021
Merged

Modify send_data_3d in diag_manager.F90 to move SELECT TYPE blocks out of triple do loops#8
MinsukJi-NOAA merged 14 commits into
NOAA-EMC:fms_mixedmodefrom
MinsukJi-NOAA:feature/mji_mixedmode

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator

@MinsukJi-NOAA MinsukJi-NOAA commented Nov 3, 2021

Regarding this PR, the following tests have been conducted:

  • CI tests (with GNU) all passed.
  • cpld_control_p7 test on Hera
    • With 64 bit dycore and 64 bit FMS, results reproduce the baseline
    • With 32 bit dycore and 64 bit FMS, results do not reproduce the baseline
    • As a side note, the test with 32 bit dycore runs 15% faster than that with 64 bit dycore
  • control test on Hera
    • With 32 bit dycore and 64 bit FMS, results do not reproduce the baseline
    • With 32 bit dycore and 32 bit FMS, results reproduce the baseline

Copy link
Copy Markdown

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the 32bit fv3 with 32bit fms reproduces current results, that's great!

@MinsukJi-NOAA MinsukJi-NOAA merged commit 062d6bc into NOAA-EMC:fms_mixedmode Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants