Skip to content

Modify sat_vapor_pres_k.F90 to fix cpld_control_p7 test with 32bit FV3 for atmos_4xdaily* file NaN values#7

Merged
MinsukJi-NOAA merged 12 commits into
NOAA-EMC:fms_mixedmodefrom
MinsukJi-NOAA:feature/mji_mixedmode
Nov 1, 2021
Merged

Modify sat_vapor_pres_k.F90 to fix cpld_control_p7 test with 32bit FV3 for atmos_4xdaily* file NaN values#7
MinsukJi-NOAA merged 12 commits into
NOAA-EMC:fms_mixedmodefrom
MinsukJi-NOAA:feature/mji_mixedmode

Conversation

@MinsukJi-NOAA
Copy link
Copy Markdown
Collaborator

Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.

Fixes # (issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@MinsukJi-NOAA MinsukJi-NOAA changed the title Modify sat_vapor_pres_k.F90 to fix cpld_control_p7 test with 32bit FV3 atmos for 4xdaily* file NaN values Modify sat_vapor_pres_k.F90 to fix cpld_control_p7 test with 32bit FV3 for atmos_4xdaily* file NaN values Oct 31, 2021
Copy link
Copy Markdown

@junwang-noaa junwang-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for fixing the issue!

@MinsukJi-NOAA MinsukJi-NOAA merged commit 48d5b9f into NOAA-EMC:fms_mixedmode Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants