Added Gaea C5/C6 features by AnilKumar-NOAA · Pull Request #138 · NOAA-EMC/EMC_verif-global

AnilKumar-NOAA · 2025-02-12T20:19:25Z

Adding Gaea C5 resources to config, module and machine setups and all other file dependencies.
Right now keeping this PR as a draft and go from there.
Working with Alex so we can both look at this draft and will proceed when it is ready.
-Anil

DavidHuber-NOAA

Looks like a good start, though I have some suggestions on system naming so it's easier to add C6.

Update this branch

EMC-verif_global updates for C5 and C6

AnilKumar-NOAA · 2025-03-03T14:51:19Z

@DavidHuber-NOAA This PR is up to date with all changes. Please check and ready to merge. Without Mallory, I think you are the one who can approve and merge. Thanks

DavidHuber-NOAA

Some suggestions regarding paths and sbatch scripts.

AnilKumar-NOAA

All changes looks good to me.

AnilKumar-NOAA

Reviewed all these changes one more time.

AnilKumar-NOAA · 2025-03-07T19:26:28Z

@KateFriedman-NOAA @DavidBurrows-NCO Please check the updates and let me know if any thing revert back for any reason. Thanks

DavidBurrows-NCO · 2025-03-07T19:41:15Z

@DavidHuber-NOAA Something got reverted in this PR and is showing an old version...We are looking into this issue now and will get back to you.

Verif updates mar3 Looks good to me!

plotting scripts updates per Kate F.

remove duplicate code

AnilKumar-NOAA · 2025-03-10T15:31:57Z

@KateFriedman-NOAA & @DavidHuber-NOAA Please review — @DavidBurrows-NCO and I have resolved all changes, and this is now ready to merge. Thanks!

DavidBurrows-NCO · 2025-03-11T12:16:11Z

Hello @DavidHuber-NOAA @KateFriedman-NOAA @AnilKumar-NOAA After finalizing our branch yesterday, I reran the extended C96_atm3DVar CI case on C6. That output can be found at /gpfs/f6/bil-fire8/world-shared/David.Burrows/verif_for_dave_huber/archive_v1 for pslot=C96_atm3DVar_mar10update_v1 if you are interested in looking through that again. Thanks!

DavidHuber-NOAA

Changes look good to me. Thanks!

KateFriedman-NOAA

Looks good, thanks @AnilKumar-NOAA !

KateFriedman-NOAA

Apologies, I forgot I had inline comments to resolve. Please address the comments. Thanks!

AnilKumar-NOAA · 2025-03-14T20:02:00Z

@KateFriedman-NOAA - Can you please point where we have missed to resolve the comments? Thanks

KateFriedman-NOAA · 2025-03-14T20:05:42Z

@KateFriedman-NOAA - Can you please point where we have missed to resolve the comments? Thanks

I unresolved and pinged you in each comment. There are Hera modulefile lines in both of the Gaea modulesfiles that need to be removed and an incorrect path in ush/set_up_verif_global.sh. Thanks!

fix C5 fix path

AnilKumar-NOAA

looks good to me!

KateFriedman-NOAA

Looks good, thanks for making these changes @AnilKumar-NOAA !

AliciaBentley-NOAA · 2025-03-17T13:29:27Z

Hi everyone. I have taken a look at this PR at Kate's request. I only see a few things that give me pause. The first is that MET-9.1.3 was created using much older versions of Python (version 3.8.6) than the ones swapped in this PR (version 3.11). You may run into issues as you move to Python 3.11, for example. If you have tested around this and things work, that's great. Just something to keep an eye on. Also, please note that a handful of Hera, Orion, and Hercules paths were changed in this PR, although it primarily to update GAEAC5 and GAEAC6. Thanks!

AnilKumar-NOAA · 2025-03-17T13:33:32Z

Looks good, thanks for making these changes @AnilKumar-NOAA !

Thanks @DavidBurrows-NCO @KateFriedman-NOAA.

…8 analysis resources (#3463) # Description This PR updates the tags for verif-global, the TC tracker, and Fit2Obs to include Gaea support for each. Additionally, it updates the resources for the C768 and C1152 analyses to use the same resources as WCOSS2. This allowed the C768 analysis to run to completion for a few test dates (2024092600-2024092618). C1152 has not been tested. Lastly, it reenables support for METplus jobs on Hera. Resolves #2639 Resolves #3402 Resolves #3449 Resolves #3370 Resolves #3371 # Type of change - [x] Bug fix (fixes something broken) - [x] New feature (adds functionality) - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics - Is this a breaking change (a change in existing functionality)? NO - Does this change require a documentation update? YES - Does this change require an update to any of the following submodules? YES - [x] EMC verif-global NOAA-EMC/EMC_verif-global#138 # How has this been tested? The tracker has been tested on all platforms. Fit2Obs has been extensively tested on C6, but not elsewhere. The analysis resources were tested on C6 as well for a cycled hybrid 4DVar case. Hera support for verif-global was also tested. Additional testing will be performed through CI tests on WCOSS2 before marking this ready for review. # Checklist - [x] Any dependent changes have been merged and published - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have documented my code, including function, input, and output descriptions - [x] My changes generate no new warnings - [ ] New and existing tests pass with my changes - [x] This change is covered by an existing CI test or a new one has been added - [x] I have made corresponding changes to the system documentation if necessary --------- Co-authored-by: kate.friedman <kate.friedman@noaa.gov>

Added Gaea C5 features

4e973ab

DavidHuber-NOAA reviewed Feb 13, 2025

View reviewed changes

Comment thread parm/config/config.vrfy Outdated

Comment thread scripts/exgrid2grid_step2.sh Outdated

Comment thread ush/build_webpage.py Outdated

DavidHuber-NOAA reviewed Feb 13, 2025

View reviewed changes

Comment thread scripts/exsatellite_step1.sh

DavidHuber-NOAA reviewed Feb 13, 2025

View reviewed changes

Comment thread ush/set_up_verif_global.sh Outdated

DavidBurrows-NCO and others added 13 commits February 19, 2025 13:55

test

ff1c851

Merge branch 'NOAA-EMC:develop' into c5c6

2f73cd6

first round of C5 and C6 updates

e8f070c

module files for c5 and c6

ef4b303

Added GAEA C5 & C6

bdacb00

Updated gaea c5/c6

70ca298

updates for runnings step2

b317f0d

update c5 Core module ver

1b65b02

Updated GAEA C6 dirs paths

04558a5

Gaea C6 Dir path updated

ba1d9f5

swap python

df5dd6b

update c5/c6 nodes

1adf890

add C5/C6 to plotting scripts and cartopy

647218b

AnilKumar-NOAA changed the title ~~Added Gaea C5 features~~ Added Gaea C5/C6 features Mar 3, 2025

AnilKumar-NOAA and others added 3 commits March 3, 2025 09:21

Merge pull request #1 from NOAA-EMC/develop

c7ee013

Update this branch

Merge branch 'features_gaea' into c5c6

2dbef6c

Merge pull request #2 from NOAA-EPIC/c5c6

08b4b18

EMC-verif_global updates for C5 and C6

AnilKumar-NOAA marked this pull request as ready for review March 3, 2025 14:49

DavidHuber-NOAA reviewed Mar 3, 2025

View reviewed changes

DavidHuber-NOAA requested a review from KateFriedman-NOAA March 3, 2025 16:31

DavidBurrows-NCO added 3 commits March 3, 2025 17:05

clean up suggested by Dave H.

bdf7c58

remove extra fix def

e5dc250

add partition

a004d39

AnilKumar-NOAA commented Mar 3, 2025

View reviewed changes

Comment thread ush/set_up_verif_global.sh Outdated

Comment thread ush/run_verif_global_in_global_workflow.sh Outdated

AnilKumar-NOAA commented Mar 3, 2025

View reviewed changes

AnilKumar-NOAA added 2 commits March 7, 2025 14:30

Added gaea c5/c6 cartopy paths

69e41e2

Updated gaeac5/c6 paths

6993e29

DavidHuber-NOAA reviewed Mar 7, 2025

View reviewed changes

Comment thread parm/config/config.vrfy Outdated

DavidHuber-NOAA reviewed Mar 7, 2025

View reviewed changes

Comment thread parm/config/config.vrfy

AnilKumar-NOAA and others added 7 commits March 7, 2025 15:31

Merge branch 'NOAA-EMC:develop' into features_gaea

f14b89a

Merge branch 'features_gaea' into verif_updates_mar3

842fb0d

Merge pull request #6 from NOAA-EPIC/verif_updates_mar3

6349fb2

Verif updates mar3 Looks good to me!

plotting scripts updates

5162160

Merge pull request #7 from NOAA-EPIC/verif_updates_mar3

3d6aa18

plotting scripts updates per Kate F.

remove duplicate code

d4e6043

Merge pull request #8 from NOAA-EPIC/verif_updates_mar3

623581a

remove duplicate code

AnilKumar-NOAA requested a review from KateFriedman-NOAA March 11, 2025 14:56

DavidHuber-NOAA approved these changes Mar 11, 2025

View reviewed changes

KateFriedman-NOAA approved these changes Mar 14, 2025

View reviewed changes

Comment thread modulefiles/emc_verif_global_gaeac5.lua Outdated

Comment thread modulefiles/emc_verif_global_gaeac6.lua Outdated

Comment thread ush/set_up_verif_global.sh Outdated

KateFriedman-NOAA suggested changes Mar 14, 2025

View reviewed changes

DavidBurrows-NCO and others added 2 commits March 17, 2025 07:54

fix C5 fix path

cfe1bb1

Merge pull request #9 from DavidBurrows-NCO/march17_updates

3f553f9

fix C5 fix path

AnilKumar-NOAA commented Mar 17, 2025

View reviewed changes

KateFriedman-NOAA approved these changes Mar 17, 2025

View reviewed changes

KateFriedman-NOAA merged commit ecb31f4 into NOAA-EMC:develop Mar 17, 2025

DavidHuber-NOAA mentioned this pull request Mar 18, 2025

Updates for Gaea: verif-global tag, tracker tag, Fit2Obs tag, and C768 analysis resources NOAA-EMC/global-workflow#3463

Merged

13 tasks

Conversation

AnilKumar-NOAA commented Feb 12, 2025

Uh oh!

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnilKumar-NOAA commented Mar 3, 2025

Uh oh!

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AnilKumar-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AnilKumar-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

AnilKumar-NOAA commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

DavidBurrows-NCO commented Mar 7, 2025

Uh oh!

AnilKumar-NOAA commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DavidBurrows-NCO commented Mar 11, 2025

Uh oh!

DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

AnilKumar-NOAA commented Mar 14, 2025

Uh oh!

KateFriedman-NOAA commented Mar 14, 2025

Uh oh!

AnilKumar-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

AliciaBentley-NOAA commented Mar 17, 2025

Uh oh!

AnilKumar-NOAA commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AnilKumar-NOAA commented Mar 10, 2025 •

edited

Loading