Feature/hera_preprocess_gefs#7
Merged
JessicaMeixner-NOAA merged 17 commits intoMar 17, 2020
Merged
Conversation
Contributor
Author
|
Correct, we don't need this file at repository.
…On Thu, Mar 12, 2020 at 3:18 PM Jessica Meixner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/0Read_me_missing_GEFS
<#7 (comment)>
:
> +2009080618 --> recovered (02/04)
+2009080700 --> recovered (02/04)
+2010121512 --> recovered (02/04)
+2012120212 --> recovered (01/23)
+2013051800 --> recovered (02/04)
+2015022712 --> recovered (02/04)
+2015083018 --> recovered (02/04)
+2016043000 --> recovered (02/04)
+2017031512 --> recovered (02/04)
+2017031618 --> recovered (02/04)
+2017031812 --> recovered (02/04)
+2018041700 --> recovered (01/22)
+2019070806 --> recovered (02/04)
+
+
+#---- massages in error
That's great! I don't think we need this file in the repository then,
correct?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E3G7PZOO7D6HRXL6JLRHEYPNANCNFSM4LGSRPAQ>
.
|
Contributor
Author
|
updated 0readme file
…On Thu, Mar 12, 2020 at 3:18 PM Jessica Meixner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/0readme
<#7 (comment)>
:
> @@ -0,0 +1 @@
+conv_gefs2datm
Thanks! This is great information. Can you also add information on how to
run the conversion from the original file format to netcdf? And either list
or say where we can find more information on if any assumptions were made
or how values were calculated?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E7WK6LKMAXRRS33HA3RHEYOFANCNFSM4LGSRPAQ>
.
|
Contributor
Author
|
Updated 0readme file
…On Thu, Mar 12, 2020 at 3:43 PM Jessica Meixner ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/0readme
<#7 (comment)>
:
> @@ -0,0 +1 @@
+conv_gefs2datm
Thank you for the instructions on how to run the script. Can you also put
where to find more information about any fields that are modified other
than being changed to netcdf format?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E4AOVAXFTBZFVUSY3DRHE3MHANCNFSM4LGSRPAQ>
.
|
flampouris
suggested changes
Mar 13, 2020
There was a problem hiding this comment.
@hyunchul386 very important job and clean fortran code!
But as is, it does not run for anybody else on Hera.
I look forward to having the code updates to my comments below and merging the code.
flampouris
reviewed
Mar 13, 2020
Contributor
Author
|
Updated conv_gefs2datm.fort.csh
…On Fri, Mar 13, 2020 at 9:41 AM flampouris ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/conv_gefs2datm.fort.csh
<#7 (comment)>
:
> @@ -0,0 +1,52 @@
+#! /bin/csh -x
+#-- ***@***.***
+
+module load NetCDF/4.5.0
+
+set hdir = /scratch2/NCEPDEV/climate/Hyun-Chul.Lee/GEFS
+set sdir = ${hdir}/Reanal
+set tdir = ${hdir}/GEFS2DATM
+set wdir = ${hdir}/Work
"mkdir -p" for all the *dir is missing
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E73MW5NRMDZCMGWQKDRHIZYVANCNFSM4LGSRPAQ>
.
|
flampouris
suggested changes
Mar 13, 2020
flampouris
left a comment
flampouris
left a comment
There was a problem hiding this comment.
@hyunchul386 thank you for the updates.
Still, the application fails and the conv_gefs2datm/0Read_me_missing_GEFS file is still there.
Please remove the file, and test the app before the next review iteration.
Thank you.
Contributor
Author
|
I have used it, and let me know what you have failed.
…On Fri, Mar 13, 2020 at 11:45 AM flampouris ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@hyunchul386 <https://github.com/hyunchul386> thank you for the updates.
Still, the application fails and the conv_gefs2datm/0Read_me_missing_GEFS
file is still there.
Please remove the file, and test the app before the next review iteration.
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E4UVCZGMHUUDUZGCNLRHJIJHANCNFSM4LGSRPAQ>
.
|
|
From my original review:
The scripts are using intel compiler without loading the appropriate modules. Please, check out your branch to a different directory and test it. The application needs a couple more updates to stop failing. |
Contributor
Author
|
Updated comp_f77_code.csh.
…On Fri, Mar 13, 2020 at 6:06 PM flampouris ***@***.***> wrote:
From my original review:
`module load *intel* netcdf
The scripts are using intel compiler without loading the appropriate
modules.
Please, check out your branch to a different directory and test it. The
application needs a couple more updates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E7LCSLLQPIODLMTDX3RHKU43ANCNFSM4LGSRPAQ>
.
|
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
reviewed
Mar 16, 2020
flampouris
suggested changes
Mar 16, 2020
flampouris
left a comment
flampouris
left a comment
There was a problem hiding this comment.
@hyunchul386 please go through the last bunch of my comments and modify your code and scripts.
Contributor
Author
|
No netcdf is used here
…On Mon, Mar 16, 2020 at 11:21 AM flampouris ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/comp_f77_code.csh
<#7 (comment)>
:
> @@ -0,0 +1,8 @@
+#! /bin/csh
+module load intel/19.0.4.243
+module load impi/2019.0.4
+
+set name = $1
+#--- in hera
Clean code --> Easier to make a Makefile:
set FFLAGS='extend-source 132'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73EYF2EFBCZBMWPVQKJLRHY7XPANCNFSM4LGSRPAQ>
.
|
Contributor
Author
|
I think it is okay with blank line
…On Mon, Mar 16, 2020 at 11:24 AM flampouris ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/comp_f77_code.csh
<#7 (comment)>
:
> @@ -0,0 +1,8 @@
+#! /bin/csh
+module load intel/19.0.4.243
+module load impi/2019.0.4
+
+set name = $1
+#--- in hera
+ifort -132 ${name}.f -o ${name} -L/apps/netcdf/4.6.1/intel/16.1.150/lib -lnetcdff
+
Remove blank lines
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E6HVUFQXWXY7K7EVMDRHZACLANCNFSM4LGSRPAQ>
.
|
Contributor
Author
|
Updated.
Just curious, is intel 19 buggy for f77?
…On Mon, Mar 16, 2020 at 11:19 AM flampouris ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In utilities/conv_gefs2datm/comp_f77_code.csh
<#7 (comment)>
:
> @@ -0,0 +1,8 @@
+#! /bin/csh
+module load intel/19.0.4.243
intel19 is buggy, lets use the default:
module load intel
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E6RSORTIXSWFELGGXLRHY7ONANCNFSM4LGSRPAQ>
.
|
it is used to compile the code... |
Contributor
Author
|
Actually, " module load netcdf/4.6.1 " in conv_gefs2datm.fort.csh
…On Mon, Mar 16, 2020 at 11:49 AM flampouris ***@***.***> wrote:
No netcdf is used here
it is used to compile the code...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADQ73E4PWCMKFAWJ35VDQPTRHZDA7ANCNFSM4LGSRPAQ>
.
|
Necessary updates
Feature/hera preprocess gefs
flampouris
approved these changes
Mar 17, 2020
JessicaMeixner-NOAA
approved these changes
Mar 17, 2020
DeniseWorthen
referenced
this pull request
in DeniseWorthen/DATM-MOM6-CICE5
Apr 22, 2020
Feature/hera_preprocess_gefs (#7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conv_gefs2datm : Convert input data from GEFS to DATM