Modify CMEPS for ufsdev_ruclsm#84
Merged
Merged
Conversation
37 tasks
Collaborator
|
@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused. |
Author
No, I just followed ufs-community/ufs-weather-model#1646 (comment) |
Collaborator
|
Thanks. We do need a PR if you are changing something in CMEPS. So we need this change, but something else is also going on because the compile is still failing, right? |
|
After 3 more commits the problem with compiling with CMEPS is resolved. |
|
This PR needs to be merged so we can merge #1646 before the deadline. |
DeniseWorthen
approved these changes
Mar 31, 2023
|
@BrianCurtis-NOAA @junwang-noaa can you approve this pr and merge? |
BrianCurtis-NOAA
approved these changes
Mar 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Testing performed if application target is CESM:
Testing performed if application target is UFS-coupled:
Testing performed if application target is UFS-HAFS:
Hashes used for testing: