Skip to content

Modify CMEPS for ufsdev_ruclsm#84

Merged
DeniseWorthen merged 4 commits into
NOAA-EMC:emc/developfrom
tanyasmirnova:ufsdev_ruclsm
Mar 31, 2023
Merged

Modify CMEPS for ufsdev_ruclsm#84
DeniseWorthen merged 4 commits into
NOAA-EMC:emc/developfrom
tanyasmirnova:ufsdev_ruclsm

Conversation

@RatkoVasic-NOAA
Copy link
Copy Markdown

Description of changes

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines:
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch/hash:

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

@RatkoVasic-NOAA
Copy link
Copy Markdown
Author

@RatkoVasic-NOAA Does this fix resolve the compile error or not? I'm a bit confused.

No, I just followed ufs-community/ufs-weather-model#1646 (comment)
Maybe I should change this to draft!?

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

DeniseWorthen commented Mar 24, 2023

Thanks. We do need a PR if you are changing something in CMEPS.

So we need this change, but something else is also going on because the compile is still failing, right?

@tanyasmirnova
Copy link
Copy Markdown

After 3 more commits the problem with compiling with CMEPS is resolved.

@SamuelTrahanNOAA
Copy link
Copy Markdown

This PR needs to be merged so we can merge #1646 before the deadline.

@jkbk2004
Copy link
Copy Markdown

@BrianCurtis-NOAA @junwang-noaa can you approve this pr and merge?

@DeniseWorthen DeniseWorthen merged commit 91bcb84 into NOAA-EMC:emc/develop Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants