Feature/updcmeps#7
Conversation
…water_option Update TFREEZE_SALTWATER_OPTION value for MOM6
cleanup and changes to be consistent with nems
more update for HAFS app
Change a few comments
remove error codes on LOGMSG write remote chk_error on return codes from LOGMSG writes
Feature/updcmeps Fixes minor bug when using FB_diagnose in prep_ocn Adds reading dbug_flag from configuration file Code clean-up: Removes return code for LogWrites and associated chkerr calls
|
One wcoss regression test failed due to 'ice_gather_scatter' error at startup. This is a random error which I have only seen after switching to the rt.sh system. I don't think I ever saw it when using the CompsetRunner. I am re-running all the wcoss tests now and will post new logs. The same test failed again on wcoss. I then ran the develop branch and it also failed in the same test on wcoss. Issue #164 |
| call FB_getFldPtr(is_local%wrap%FBImp(compice,compice) , 'Si_ifrac', Si_ifrac, rc=rc) | ||
| if (ChkErr(rc,__LINE__,u_FILE_u)) return | ||
| call FB_getFldPtr(is_local%wrap%FBImp(compice,compice) , 'Si_imask', Si_imask, rc=rc) | ||
| call FB_getFldPtr(is_local%wrap%FBImp(compice,compice) , 'Si_imask' , Si_imask, rc=rc) |
There was a problem hiding this comment.
I will double check the several white space changes. They should all be in the merge to ESCOMP and will go into our emc/develop w/ this PR.
| if (med_map_RH_is_created(is_local%wrap%RH(compice,compatm,:),mapfcopy, rc=rc)) then | ||
| ! TODO (mvertens, 2019-11-20): this is not being used when ice and atm are on the same grid | ||
| ! - this needs to be implemented | ||
| maptype = mapfcopy |
There was a problem hiding this comment.
I am curious, do we need this?
There was a problem hiding this comment.
I suspect this has to do with one of the CESM non-active configurations, when atm and ice are the same grid. I don't think this is something we will need.
|
|
||
| call med_methods_FB_diagnose(FB, 'read '//trim(fname), rc) | ||
| if (present(flag)) flag = .true. | ||
| if (present(flag)) flag = .true. |
There was a problem hiding this comment.
should we keep the space?
|
I just want to confirm: We are OK to merge this to emc/develop even though the single test failed on dell-p3? |
|
I think we need to fix the issue before we can commit. If develop branch
has the same issue, we need to fix that as an emergency commit before we do
any future commit.
…On Mon, Aug 17, 2020 at 9:15 AM Denise Worthen ***@***.***> wrote:
I just want to confirm: We are OK to merge this to emc/develop even though
the single test failed on dell-p3?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#7 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TML6D4U33DSOTIHPXDSBEUM5ANCNFSM4P7NSVCQ>
.
|
|
All regression tests now pass. Logs are posted at S2S PR #163 |
shr_flux_mod change
7 participants
Updates to latest ESCOMP/master
Fixes minor bug in FB_diagnose
Removes return code from LOGMSG and associated chkerr calls
minor code cleanup
No changes to baselines. Logs are posted at associated UFS-S2S PR 163