Skip to content

DRAFT: Enable to change source and destination mask for interpolation#59

Closed
uturuncoglu wants to merge 1 commit into
NOAA-EMC:developfrom
uturuncoglu:feature/mask
Closed

DRAFT: Enable to change source and destination mask for interpolation#59
uturuncoglu wants to merge 1 commit into
NOAA-EMC:developfrom
uturuncoglu:feature/mask

Conversation

@uturuncoglu
Copy link
Copy Markdown
Collaborator

Description of changes

This PR aims to bring feature of changing source and destination masks via configuration file (ESMF config). This is especially important for the CDEPS inline capability since we have no control in destination mask.

Specific notes

Contributors other than yourself, if any: N/A

CDEPS Issues Fixed (include github issue #): None

Are there dependencies on other component PRs (if so list): No

Are changes expected to change answers (bfb, different to roundoff, more substantial): No

Any User Interface Changes (namelist or namelist defaults changes):
The two new optional namelist option is introduced to the config file: stream_src_mask and stream_dst_mask to control mask values. The deafest are zero which does not change the existing behavior.

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
This is initially tested under UFS Weather Model and did. not change the answer for hafs_regional_atm_ocn_wav and cpld_control_p8 cases. More test will be performed with both UFS Weather model and also CESM.

Hashes used for testing:
Used hash for UFS Weather model is 318295476a797851f98b5485444336cfe6d62e24

@uturuncoglu
Copy link
Copy Markdown
Collaborator Author

Based on discussion with @DeniseWorthen and @BinLiu-NOAA I am closing this PR since I created new one in authoritative repository - ESCOMP#259. Once that is merged, we need to sync NOAA-EMC/CDEPS fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant