DRAFT: Enable to change source and destination mask for interpolation#59
Closed
uturuncoglu wants to merge 1 commit into
Closed
DRAFT: Enable to change source and destination mask for interpolation#59uturuncoglu wants to merge 1 commit into
uturuncoglu wants to merge 1 commit into
Conversation
42 tasks
Collaborator
Author
|
Based on discussion with @DeniseWorthen and @BinLiu-NOAA I am closing this PR since I created new one in authoritative repository - ESCOMP#259. Once that is merged, we need to sync NOAA-EMC/CDEPS fork. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR aims to bring feature of changing source and destination masks via configuration file (ESMF config). This is especially important for the CDEPS inline capability since we have no control in destination mask.
Specific notes
Contributors other than yourself, if any: N/A
CDEPS Issues Fixed (include github issue #): None
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers (bfb, different to roundoff, more substantial): No
Any User Interface Changes (namelist or namelist defaults changes):
The two new optional namelist option is introduced to the config file:
stream_src_maskandstream_dst_maskto control mask values. The deafest are zero which does not change the existing behavior.Testing performed (e.g. aux_cdeps, CESM prealpha, etc):
This is initially tested under UFS Weather Model and did. not change the answer for
hafs_regional_atm_ocn_wavandcpld_control_p8cases. More test will be performed with both UFS Weather model and also CESM.Hashes used for testing:
Used hash for UFS Weather model is 318295476a797851f98b5485444336cfe6d62e24