Update CDEPS to include the recent changes from ESCOMP/CDEPS#49
Merged
Conversation
* fix restarts using coszen angle time interpolation - cleaned up restart writes and fixes to have the following test pass ERS_Ly3_P72x2.f10_f10_mg37.IHistClm50Sp.cheyenne_intel
add call to pio_init
* added skip_restart_read logic needed for CTSM spin-up runs * fixes for getting streams with vector fields to work correctly Co-authored-by: Jim Edwards <jedwards@ucar.edu>
The problem encountered in nldas2 is that both the mesh had a mask of zero over ocean points and the route handle for the mapping of streams to the model resolution uses zeroregion=ESMF_REGION_TOTAL. As a result, all mapped values over ocean were set to zero. This is a real problem if the variable is surface pressure. Since the values over ocean are never used, the solution is to simply set a valid value of surface pressure over ocean.
Corrects CIME path in buildnml scripts.
Add the missing RYF DROF stream entries in xml files
Actually add a read for ZBOT in the streams for CLMNCEP fixing ESCOMP#168
Description of changes Need to add a _FillValue attribute. Specific notes Contributors other than yourself, if any: CDEPS Issues Fixed (include github issue #): Are there dependencies on other component PRs (if so list): Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb Any User Interface Changes (namelist or namelist defaults changes): no Testing performed (e.g. aux_cdeps, CESM prealpha, etc): ERS_Ld3.f45_g37_rx1.A.cheyenne_intel Hashes used for testing: cesm commit e79aed81d07 (alpha09d)
Need to use os.getenv("PIO_LIBDIR") instead of os.environ["PIO_LIBDIR"] to avoid a hang on some systems.
…ESCOMP#177) Co-authored-by: Jim Edwards <jedwards@ucar.edu>
Co-authored-by: Jim Edwards <jedwards@ucar.edu>
* addition -f new streams for datm * fixes for getting streams with vector fields to work correctly * added ndep stream data * added ndep stream functionality * fixed compile bug * more updates * added ndep to core2 and jra forcing * updated stream definition file
* move pio initialization * fix env var access
This was referenced Aug 17, 2022
junwang-noaa
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The CDEPS will be updated to include changes from 20220811 (# a42fb93)
Specific notes
Updates from ESCOMP/CDEPS include the following features:
CDEPS Issues Fixed (include github issue #):
#48
Are there dependencies on other component PRs (if so list): No
Are changes expected to change answers: No
Any User Interface Changes (namelist or namelist defaults changes): No
Testing performed: UFS cdeps tests