Add Fortran module for GEFS data source in CDEPS#13
Merged
Conversation
Author
|
A related PR for ufs-weather-model will be submitted. |
junwang-noaa
approved these changes
Mar 11, 2021
uturuncoglu
requested changes
Mar 12, 2021
Collaborator
uturuncoglu
left a comment
uturuncoglu
left a comment
There was a problem hiding this comment.
I could not see CDEPS CFSR specific module file in here. Maybe you forgot to add it to PR.
| ! Sa_ptem(n) = Sa_tbot(n) | ||
| end do | ||
|
|
||
| !---------------------------------------------------------- |
Collaborator
There was a problem hiding this comment.
If there is no need to unit conversion. This part of code can be cleaned.
Collaborator
Sorry, that was already merged in previous PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The Fortran module for GEFS data source will be added to CDEPS.
Specific notes
The revised code will include the following changes:
Testing performed:
Tests have been done in the mom6_cice6_cdeps application using a revised CMEPS code from ESCOMP/CMEPS (#74f7751, March 5, 2021 version).