Remove compiler warnings and remarks for AQMv7 implementation#94
Merged
BrianCurtis-NOAA merged 4 commits intoNov 11, 2023
Merged
Conversation
Contributor
|
@rmontuoro Have you done any test on this PR? |
JianpingHuang-NOAA
approved these changes
Nov 10, 2023
Collaborator
|
@JianpingHuang-NOAA can you please run AQM with these changes (if you haven't yet) to make sure the results are not changing. I don't expect them to. As soon as you confirm we can merge this. |
BrianCurtis-NOAA
approved these changes
Nov 11, 2023
Contributor
|
@BrianCurtis-NOAA I have done the test. Everything is good. Do we need to open a PR to merge the changes to the ufs-weather-model? |
Collaborator
We can bring these changes into the weather model later. I'll merge this in now. |
42 tasks
BrianCurtis-NOAA
pushed a commit
to BrianCurtis-NOAA/AQM
that referenced
this pull request
May 8, 2024
…MC#94) * Remove IOAPI build warnings (Issue NOAA-EMC#93) * Remove STENEX/noops build warnings (Issue NOAA-EMC#93) * Fix edit descriptor to remove compiler remarks for CSQY_DATA (Issue NOAA-EMC#93) * Fix edit descriptor to remove compiler remarks for ISORROPIA code (Issue NOAA-EMC#93)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.
New or updated input data is required by this PR.
Baselines are expected to change.
Description
Issue(s) addressed
This PR removes the compiler warnings referenced in Issue #93 and fixes edit descriptors in the original CMAQ source code leading to compiler remarks.
The changes included in this PR passed regression testing on Cactus.
Dependencies
None