Capability addition to run using a debug build of UFSWM#65
Conversation
|
RegressionTests_wcoss2.intel.log Proof log shows no debug baseline and fails regional_atmaq |
|
@JianpingHuang-NOAA Please review. |
JianpingHuang-NOAA
left a comment
JianpingHuang-NOAA
left a comment
There was a problem hiding this comment.
One more comment but not directly related to this change. Is "-D32BIT=ON" included in the CMAKE_FLAGS for the UFSWM compilation for AQM app.?
No, we do not use -D32BIT=ON, should we? |
|
I have included "use -D32BIT=ON" when I compiled the ufswm code. It does not affect the results but may save about 5% fcst model running time. Please include it for aqm application. |
|
Do we need another PR on the change of -D32BIT=ON? |
I've already added it to this PR in UFSWM. I'm running RT's now. I want to confirm, you ran the Science tests for this PR with -D32BIT=ON, correct? |
|
I thinks so. It is originally suggested by Barry. Actually I have included it into all of my retro and NRT runs. |
|
UFSWM RT's were reproducible. Merging this in. |
* Update aqm_files.cmake to use CMAQ's aero_depv * remove aero_depv.F from src/model/src * tab fixes in aqm_files.cmake and remove extra debugging calls from vdiffacmx.F
2 participants
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
This PR has been tested with the ufs-srweather-app workflow online-cmaq branch. (Confirmed through discussions with @JianpingHuang-NOAA )
New or updated input data is required by this PR.
Baselines are expected to change.
Description
This PR removes a locally edited version of aero_depv.F in favor of the CMAQ version.
Also to be noted is that using init_concentrations = true in aqm.rc will cause debug build to fail at runtime. I have conversed with @JianpingHuang-NOAA who stated that init_concentrations is set to false in the operational setting.
Issue(s) addressed
Dependencies
No Dependencies.