Bug fixes to allow compile and run the RT test in debug mode.#126
Merged
KaiWang-NOAA merged 5 commits intoFeb 27, 2026
Merged
Conversation
Contributor
|
@KaiWang-NOAA @bbakernoaa Reopened. Testing in RT asap. |
…herwise, RT debug test fails for subgrid clouds when canopy on (non-debug RT test runs okay).
…rid clouds to allow RT test in debug mode when canopy on (non-debug RT test runs okay).
33 tasks
|
Could we get a review on this PR so that we can process ufs-community/ufs-weather-model#3060? Thanks! |
BrianCurtis-NOAA
requested changes
Feb 24, 2026
|
@iri01 Will you be able to make these changes by 2pm ET, or should we reschedule ufs-community/ufs-weather-model#3060? EDIT: Looks like you may have just committed! Let me know when changes are final. :) |
Contributor
|
The AQM changes by @iri01 have been pushed. Just need to update submodule
here?
…On Tue, Feb 24, 2026, 12:57 PM Gillian Petro ***@***.***> wrote:
*gspetro-NOAA* left a comment (NOAA-EMC/AQM#126)
<#126 (comment)>
@iri01 <https://github.com/iri01> Will you be able to make these changes
by 2pm ET, or should we reschedule ufs-community/ufs-weather-model#3060
<ufs-community/ufs-weather-model#3060>?
—
Reply to this email directly, view it on GitHub
<#126 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNVSDPBHH4JNH3D26JD4NSGHDAVCNFSM6AAAAACV23URECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNJTG44DCOJWHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
|
Did we miss anything @gspetro-NOAA?
On Tue, Feb 24, 2026, 1:06 PM Patrick Campbell ***@***.***>
wrote:
… The AQM changes by @iri01 have been pushed. Just need to update submodule
here?
On Tue, Feb 24, 2026, 12:57 PM Gillian Petro ***@***.***>
wrote:
>
> left a comment (NOAA-EMC/AQM#126)
> <#126 (comment)>
>
> @iri01 <https://github.com/iri01> Will you be able to make these changes
> by 2pm ET, or should we reschedule ufs-community/ufs-weather-model#3060
> <ufs-community/ufs-weather-model#3060>?
>
> —
> Reply to this email directly, view it on GitHub
> <#126 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGLFYNVSDPBHH4JNH3D26JD4NSGHDAVCNFSM6AAAAACV23URECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTSNJTG44DCOJWHA>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
BrianCurtis-NOAA
previously approved these changes
Feb 24, 2026
Contributor
|
Thanks Brian!
…On Tue, Feb 24, 2026, 1:12 PM Brian Curtis ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#126 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGLFYNXVS3EBB4WVZJXF25D4NSH7LAVCNFSM6AAAAACV23URECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNBZG4ZDGOBWGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
|
@gspetro-NOAA Do we need to update AQM submodule in UWM again, or can you
do it for the PR?
THANKS!
On Tue, Feb 24, 2026, 1:13 PM Patrick Campbell ***@***.***>
wrote:
… Thanks Brian!
On Tue, Feb 24, 2026, 1:12 PM Brian Curtis ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> —
> Reply to this email directly, view it on GitHub
> <#126 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGLFYNXVS3EBB4WVZJXF25D4NSH7LAVCNFSM6AAAAACV23URECVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNBZG4ZDGOBWGY>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
|
|
@drnimbusrain I updated the AQM hash. Two pairs of eyes are better than one tho. Let me know if everything looks ok in ufs-community/ufs-weather-model#3060. |
Contributor
Looks good to me @gspetro-NOAA Thanks! |
… timeInterval zero.
KaiWang-NOAA
approved these changes
Feb 26, 2026
|
Testing completed successfully for ufs-community/ufs-weather-model#3060. This PR can be merged. |
Collaborator
|
@gspetro-NOAA @drnimbusrain Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.
New or updated input data is required by this PR.
Baselines are expected to change.
Description
Issue(s) addressed
Dependencies