Bring in additional changes from production/AQM.v7 and reversed the Rsnow value#121
Merged
KaiWang-NOAA merged 9 commits intoOct 21, 2025
Merged
Conversation
Update ASX_DATA_MOD.F to reverse Rsnow to 1000 which is consistent with AQMv7 and CMAQv5.2.1
KaiWang-NOAA
added
enhancement
This was referenced Sep 18, 2025
BrianCurtis-NOAA
previously approved these changes
Sep 18, 2025
Collaborator
Author
|
@BrianCurtis-NOAA I just reverted two commits from this PR to bypass the intel debug failure. We'll bring back the related changes in the near future once resolving the debug-mode issue. Could you please review and approve the changes? |
BrianCurtis-NOAA
approved these changes
Oct 20, 2025
|
Testing on #2893 is complete, please continue with merging, thank you. |
Collaborator
Author
|
@ *FernandoAndrade-NOAA* AQM PR#121 is merged. Thanks.
…On Tue, Oct 21, 2025 at 11:52 AM Fernando Andrade - NOAA < ***@***.***> wrote:
*FernandoAndrade-NOAA* left a comment (NOAA-EMC/AQM#121)
<#121 (comment)>
Testing on #2893
<ufs-community/ufs-weather-model#2893> is
complete, please continue with merging, thank you.
—
Reply to this email directly, view it on GitHub
<#121 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2A5ALUT7CH2RFQ7IMKXAEL3YZJCFAVCNFSM6AAAAACG4MUVHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRXGM3DIOBSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Kai Wang, Ph.D.
Lynker at NOAA/NWS/NCEP/EMC
5830 University Research Ct., Rm. 2029
College Park, MD 20740
***@***.***
(301) 683-3230
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will bring in multiple commits introduced in the production/AQM.v7 branch to address the EE2 compliance issues as well as updated point source emission coding and also reverse Rsnow to 1000 which is consistent with AQMv7 to address the large overprediction of O3 over snow-covered regions in AQMv8/CMAQv5.4
PR Checklist
This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:
This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.
New or updated input data is required by this PR.
Baselines are expected to change.
Issue(s) addressed
#113
Dependencies