Skip to content

A temporary solution to fix erroneous values of LAI from noah-mp #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KaiWang-NOAA wants to merge 1 commit into from
Closed

A temporary solution to fix erroneous values of LAI from noah-mp #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/shr/aqm_methods.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,20 @@ LOGICAL FUNCTION XTRACT3 ( FNAME, VNAME, &
case ("HFX")
p2d => stateIn % hfx
case ("LAI")
p2d => stateIn % xlai
! p2d => stateIn % xlai
! a temporary solution provided by Patrick Campbell from ARL for GFSv17 CCPP and
! AQMv8 coupling
k = 0
do r = row0, row1
do c = col0, col1
k = k + 1
if ( stateIn % xlai(c,r) > 10.0 ) then !zero out erroneously high values
Copy link
Copy Markdown
Collaborator

@bbakernoaa bbakernoaa Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably add something here to ensure positive. this seems like a good idea regardless if the latest UWM fixed this. always good to ensure valid values.

buffer(k) = 0.0 * stateIn % xlai(c,r) !from Noah-MP option, which should
else !max out at ~ 4.5 from tables and
buffer(k) = stateIn % xlai(c,r) !~ 10 from satellite input data
end if
end do
end do
case ("LH")
p2d => stateIn % lh
case ("PRSFC")
Expand Down