Skip to content

Move MOM_generic_tracer with no changes#22

Merged
yichengt900 merged 2 commits into
NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi_to_gfdlfrom
theresa-cordero:move_MOMGT_module
Dec 31, 2024
Merged

Move MOM_generic_tracer with no changes#22
yichengt900 merged 2 commits into
NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi_to_gfdlfrom
theresa-cordero:move_MOMGT_module

Conversation

@theresa-cordero
Copy link
Copy Markdown
Collaborator

Renames src/tracer/MOM_generic_tracer.F90
to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90

Renames src/tracer/MOM_generic_tracer.F90
to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90
@yichengt900
Copy link
Copy Markdown

Hi @theresa-morrison, thanks for opening this PR. As we discussed earlier, I thought the first step we intended to take was to simply move src/tracer/MOM_generic_tracer.F90 to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90 without any code changes. This PR has accomplished the first part (creating a new file MOM_generic_tracer.F90 under config_src/external/GFDL_ocean_BGC/), but the original src/tracer/MOM_generic_tracer.F90 still exists. As a result, it caused Doxygen and Style checks to fail. Can you use git rm src/tracer/MOM_generic_tracer.F90, followed by git commit and git push, to ensure the original file is removed?

Git rm MOM_generic_tracer.F90
@theresa-cordero
Copy link
Copy Markdown
Collaborator Author

Thanks for the clear steps. Done!

@yichengt900
Copy link
Copy Markdown

Thanks, @theresa-morrison. All look good to me.

@yichengt900 yichengt900 merged commit 9b2080b into NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi_to_gfdl Dec 31, 2024
yichengt900 added a commit that referenced this pull request Dec 31, 2024
yichengt900 pushed a commit that referenced this pull request Jan 2, 2025
* Move MOM_generic_tracer with no changes

Renames src/tracer/MOM_generic_tracer.F90
to config_src/external/GFDL_ocean_BGC/MOM_generic_tracer.F90

* Remove MOM_generic_tracer

Git rm MOM_generic_tracer.F90

---------

Co-authored-by: Theresa Morrison <Theresa.Morrison@gaea68.ncrc.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants