Move MOM_generic_tracer out of MOM6#21
Closed
theresa-cordero wants to merge 2 commits into
Closed
Conversation
added 2 commits
December 16, 2024 10:12
Move MOM_generic_tracer out of MOM6 and into the externals as a stub. With this change, users of the generic tracer modules will be requied to add an active version of MOM_generic_tracer to their equivalent of the GFDL_ocean_BGC folder. This should not impact users running without generic tracers.
Remove comments and use statements from MOM_generic_tracer stub.
Collaborator
Author
|
This PR is related to PR 107. If a version of MOM6 with this change is used with a version of ocean_BGC without the changes in PR 107, then the model will fail to compile. |
yichengt900
reviewed
Dec 17, 2024
| use g_tracer_utils, only: g_tracer_type | ||
|
|
||
| use MOM_ALE_sponge, only : ALE_sponge_CS | ||
| use MOM_coms, only : EFP_type |
There was a problem hiding this comment.
Remove the trailing space at the end of the line.
yichengt900
reviewed
Dec 17, 2024
|
|
||
| use MOM_ALE_sponge, only : ALE_sponge_CS | ||
| use MOM_coms, only : EFP_type | ||
| use MOM_diag_mediator, only : diag_ctrl |
There was a problem hiding this comment.
Same here. a trailing space is detected at the end of the line
yichengt900
reviewed
Dec 17, 2024
| use MOM_open_boundary, only : ocean_OBC_type | ||
| use MOM_restart, only : MOM_restart_CS | ||
| use MOM_sponge, only : sponge_CS | ||
| use MOM_time_manager, only : time_type |
There was a problem hiding this comment.
Same. Remove the trailing space at the end of the line
|
@theresa-morrison, as you suggested, we can start with our first PR by simply moving |
Collaborator
Author
|
Closing this PR for now, a new PR has been opened to the new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move MOM_generic_tracer out of MOM6 and into the externals as a stub. With this change, users of the generic tracer modules will be requied to add an active version of MOM_generic_tracer to their equivalent of the GFDL_ocean_BGC folder.
This should not impact users running without generic tracers.
This PR is done in two commits, one where the stub has comments and extra use statements which are removed in the second commit.