Escape Message-ID during update binaries #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran misc/update/update_binaries.php manually because I noticed a lot of missing parts that weren't going away and noticed sql errors on the INSERT IGNORE. It turns out that some of the message IDs had single quotes in them that inhibited the query from executing properly. An example I found is: 200420092300004385%But-i-really@dont'care.com (oddly enough, the single quote isn't in the word don't, but after...) semi-sanitizing the data through the `addslashes` function takes care of the problem -- I'm not aware if there's a more elegant method of sanitizing that is available. Please let me know if there is and I'll update.
|
Regarding the failing test, I can't find any reference to |
|
Those come from book testing. It's using itunes api, which is incoherent and changes data from time to time. That is why the test failed. |
DariusIII
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran misc/update/update_binaries.php manually because I noticed a lot
of missing parts that weren't going away and noticed sql errors on the
INSERT IGNORE. It turns out that some of the message IDs had single
quotes in them that inhibited the query from executing properly.
An example I found is: 200420092300004385%But-i-really@dont'care.com
(oddly enough, the single quote isn't in the word don't, but after...)
semi-sanitizing the data through the
addslashesfunction takes care ofthe problem -- I'm not aware if there's a more elegant method of
sanitizing that is available. Please let me know if there is and I'll
update.