Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New benchmark runners #99

Merged
merged 8 commits into from
Feb 8, 2021
Merged

New benchmark runners #99

merged 8 commits into from
Feb 8, 2021

Conversation

alecandido
Copy link
Member

#95

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #99 (01ba64b) into develop (247d6e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #99   +/-   ##
========================================
  Coverage    71.34%   71.34%           
========================================
  Files           48       48           
  Lines         1888     1888           
========================================
  Hits          1347     1347           
  Misses         541      541           
Flag Coverage Δ
unittests 71.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@alecandido alecandido changed the base branch from master to develop February 4, 2021 12:08
@giacomomagni
Copy link
Collaborator

From my side it's possible to merge. I added a small modification in the yadmark runner to make it more flexible with the order of the points returned by the external program.

@felixhekhorn
Copy link
Contributor

running with pytest I still get 2 errors for xspace-bench:

E                   ValueError: Sort problem: x and/or Q2 do not match.
...
======================================== short test summary info ========================================
FAILED benchmarks/runners/xspace_bench_bench.py::BenchmarkPlain::benchmark_lo - ValueError: Sort probl...
FAILED benchmarks/runners/xspace_bench_bench.py::BenchmarkPlain::benchmark_nlo - ValueError: Sort prob...

please make sure to have pytest report everything passed

@felixhekhorn
Copy link
Contributor

and in qcdnum I get

E                   NotImplementedError: flavor total is not implemented!

@felixhekhorn
Copy link
Contributor

Remember to mark the conversations as "resolved" if it is ;-)

@giacomomagni giacomomagni merged commit 57368e4 into develop Feb 8, 2021
@giacomomagni giacomomagni deleted the feature/bench_runners branch February 8, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants