Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small benchmarks updates #40

Merged
merged 21 commits into from
May 11, 2020
Merged

Small benchmarks updates #40

merged 21 commits into from
May 11, 2020

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Apr 30, 2020

  • move ParentTest in a conftest.py to make it an autoimported fixture
    • give it a better name, both to class and the instances inside the test functions
  • separate commit workflow from merge workflow
  • fix coverage report

Not related

  • test and add human_dates

Not a priority

  • add options to benchmark (with a local plugin conftest.py) to silence warnings from quad
    • so if we are not interested in the full warning report we can just focus on the new ones and silence the known ones
    • put a hard-coded list where to register warnings to be silenced
  • add chance to rerun only failing benchmarks (see docs) (only for local use)

@alecandido alecandido added the test Add or improve tests label May 6, 2020
@alecandido
Copy link
Member Author

pytest do not support class fixtures ("maybe in the future" it is written in the error message since 4 years ago), in the sense that it is not possible to make a fixture out of a class, while it is perfectly fine to apply a usual fixture to a whole class in tests.

@alecandido
Copy link
Member Author

alecandido commented May 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@50dbbf4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage          ?   92.34%           
=========================================
  Files             ?       12           
  Lines             ?      457           
  Branches          ?        0           
=========================================
  Hits              ?      422           
  Misses            ?       35           
  Partials          ?        0           
Flag Coverage Δ
#benchmarks 88.62% <0.00%> (?)
#unittests 48.35% <0.00%> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50dbbf4...f222f89. Read the comment docs.

@alecandido alecandido requested a review from felixhekhorn May 11, 2020 08:40
Copy link
Member Author

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of Black mess, on the other hand they are really small updates.

@alecandido alecandido merged commit ea24fb6 into master May 11, 2020
@felixhekhorn felixhekhorn deleted the benchmarks/small-updates branch May 11, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Add or improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants