Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarks with APFEL #36

Merged
merged 11 commits into from
Apr 29, 2020
Merged

Refactor benchmarks with APFEL #36

merged 11 commits into from
Apr 29, 2020

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Apr 23, 2020

  • reorganize input files (runcards)
    • run from db (with queries)
  • reorganize apfel cache
    • hashing input dicts (try with frozendict, or better just hash(str(d)))
  • reorganize logs

in order to do that:

  • setup a lightweight proper db
  • interface with old
    • produce runcards from db
    • produce theory/observables from matrix
    • compare different logs (subtract_tables.py)
    • print comparisons (print_comparison_tables or better)
    • add subtract_tables to ParentTest

finally:

  • update the workflow to generate input.json
  • download needed PDFSets with lhapdf

@alecandido alecandido added refactor Refactor code test Add or improve tests labels Apr 24, 2020
@alecandido
Copy link
Member Author

alecandido commented Apr 27, 2020

to think about:

  • hash vs db ids

to do:

  • uniquely identify with theory and observables:
    • logs
    • apfel_cache
  • subtract tables: either identify with theory + dis_observables hashes (for logs and apfel_cache) or by the unique id (for scratch area)
    • use it as 's11' or 'scratch11' or something like that to distinguish from hashes
  • navigator: list entries in a quick form, output content

@alecandido alecandido merged commit 69ce961 into master Apr 29, 2020
@felixhekhorn felixhekhorn deleted the refactor-benchmarks branch April 29, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code test Add or improve tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant