Implementing input checks.

[alecandido]

I will implement the input checks already made in APFEL (just as they are for the moment), hopefully in a more readable fashion.

• include Inspector call in runner
• write one or more proper tests
  • errors
  • checkers
• write the checking script
  • domains
  • cross-constraints
• complete to store default and restrictions
  • domains (write for all the parameters, at least the one listed in defaults)
  • cross-constraints

UPDATE: defaults are not going to be implemented at all, because we prefer to provide examples and force the user to fully specify the input runcard

[alecandido]

@scarrazza can you link me the place where the input parsing is made in nnpdf, please?

[scarrazza]

Sure, here the cuts example: https://github.com/NNPDF/nnpdf/blob/master/validphys2/src/validphys/cuts/filters.yaml

[alecandido]

Codecov Report

Merging #12 into develop will increase coverage by 15.65%.
The diff coverage is 58.86%.

@@             Coverage Diff              @@
##           develop      #12       +/-   ##
============================================
+ Coverage    51.15%   66.81%   +15.65%     
============================================
  Files           39       44        +5     
  Lines         1386     1600      +214     
============================================
+ Hits           709     1069      +360     
+ Misses         677      531      -146     

Flag	Coverage Δ
#unittests	66.81% <58.86%> (+15.65%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/yadism/cc/fl_light.py	100.00% <ø> (ø)
src/yadism/cc/weights.py	10.00% <ø> (ø)
src/yadism/input/defaults.py	0.00% <0.00%> (ø)
src/yadism/nc/f2_heavy.py	45.00% <0.00%> (ø)
src/yadism/nc/partonic_channel.py	33.33% <0.00%> (ø)
src/yadism/tmc.py	37.50% <0.00%> (ø)
src/yadism/cc/f2_asy.py	36.58% <8.33%> (-3.42%)	⬇️
src/yadism/cc/f3_asy.py	37.50% <9.09%> (-2.50%)	⬇️
src/yadism/nc/f2_light.py	50.00% <14.28%> (+9.45%)	⬆️
src/yadism/cc/f3_heavy.py	41.17% <20.00%> (-4.98%)	⬇️
... and 34 more

[alecandido]

Task linked: CU-8jnv9d Input checks

[alecandido]

Maybe cross-constraints will be deferred to merge the domains.

Tests still required (probably) before merging. Runner integration also.