Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from docker to conda #11

Merged
merged 44 commits into from
Feb 3, 2020
Merged

Switch from docker to conda #11

merged 44 commits into from
Feb 3, 2020

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Jan 27, 2020

Because there are already implemented actions that installs conda it might be possible to install directly with conda apfel and lhapdf from the nnpdf channel, after the proper action having installed miniconda or the needed version of conda.

For example this is the miniconda action in GitHub marketplace.

  • make apfel and lhapdf working
  • why pytest installed with conda was not working? 8cac558
  • check eko dependency (currently not implemented)

@alecandido alecandido requested a review from scarlehoff January 28, 2020 09:45
@scarlehoff
Copy link
Member

It's strange that the pytest from conda was not working, but in any case, pip is probably faster :P
The linter is not added yet right? Other than that I think it's ok.

@alecandido
Copy link
Member Author

Now all is working fine, if @scarlehoff can help me to decide which package put in requirements.host and requirements.run we can reduce the dependencies and merge.

Dependency on eko still to be tested, but let's do it in another branch.

@alecandido alecandido merged commit 269ae5d into master Feb 3, 2020
@alecandido alecandido deleted the docker-to-conda-action branch March 18, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants