Skip to content

Layout.FromMethod without boxing (refactor) #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Layout.FromMethod without boxing (refactor) #5584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/NLog/Layouts/Typed/Layout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,6 @@ private sealed class LayoutGenericTypeValue : LayoutTypeValue, ILayoutTypeValue<
{
private readonly Layout<T> _ownerLayout;

public override Type InnerType => typeof(T);
public override IPropertyTypeConverter ValueTypeConverter => _ownerLayout.ValueTypeConverter;

public LayoutGenericTypeValue(Layout layout, string parseValueFormat, CultureInfo parseValueCulture, Layout<T> ownerLayout)
Expand Down Expand Up @@ -487,8 +486,8 @@ internal class LayoutTypeValue : ILayoutTypeValue
public bool ThreadAgnosticImmutable => _innerLayout.ThreadAgnosticImmutable;
public StackTraceUsage StackTraceUsage => _innerLayout.StackTraceUsage;
public virtual IPropertyTypeConverter ValueTypeConverter { get; }
public ILayoutTypeValue InnerLayout => this;
public virtual Type InnerType => null;
ILayoutTypeValue ILayoutTypeValue.InnerLayout => this;
Type ILayoutTypeValue.InnerType => _valueType;

public LayoutTypeValue(Layout layout, Type valueType, string parseValueFormat, CultureInfo parseValueCulture, IPropertyTypeConverter valueTypeConverter)
{
Expand Down Expand Up @@ -595,7 +594,7 @@ private string RenderStringValue(LogEventInfo logEvent, StringBuilder stringBuil
}
}

bool TryParseValueFromObject(object rawValue, string parseValueFormat, CultureInfo parseValueCulture, out object parsedValue)
private bool TryParseValueFromObject(object rawValue, string parseValueFormat, CultureInfo parseValueCulture, out object parsedValue)
{
try
{
Expand Down