Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogEventInfo constructor with eventProperties as IReadOnlyList #4628

Merged
merged 2 commits into from
Oct 24, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 24, 2021

Allow users to create LogEventInfo where Properties-dictionary is created with required capacity.

Have use-case where application wants to capture lots of context-properties, for later output in json-file. Instead of adding the properties one-by-one with dictionary-resize, then this will reduce memory-allocation.

@snakefoot snakefoot added the enhancement Improvement on existing feature label Oct 24, 2021
@snakefoot snakefoot added this to the 5.0 (new) milestone Oct 24, 2021
@snakefoot snakefoot force-pushed the logevent-properties-init branch 2 times, most recently from 46faa01 to 0c13d2b Compare October 24, 2021 12:45
@snakefoot snakefoot force-pushed the logevent-properties-init branch from 0c13d2b to e3f64ed Compare October 24, 2021 13:00
@snakefoot snakefoot enabled auto-merge (squash) October 24, 2021 18:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@snakefoot snakefoot merged commit 23e9974 into NLog:dev Oct 24, 2021
@snakefoot snakefoot deleted the logevent-properties-init branch July 30, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant