Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluent LogBuilder should suppress exception on invalid callerFilePath #4069

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fluent LogBuilder should suppress exception on invalid callerFilePath #4069

merged 1 commit into from
Aug 4, 2020

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Aug 3, 2020 •
edited
Loading

Resolves #4067

Trying to make pretty logger-name based on callerFilePath should not lead to exception if path-value is invalid on the platform.

@snakefoot snakefoot added the bug Bug report / Bug fix label Aug 3, 2020
@snakefoot snakefoot added this to the 4.7.4 milestone Aug 3, 2020
@snakefoot snakefoot mentioned this pull request Aug 3, 2020
Closed
@snakefoot snakefoot force-pushed the LogBuilderFluentWithoutThrowing branch from 5dce06b to 83884b8 Compare August 4, 2020 18:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@304NotModified 304NotModified merged commit ac953a9 into NLog:master Aug 4, 2020
@304NotModified
Copy link
Member

Thanks!

@snakefoot snakefoot deleted the LogBuilderFluentWithoutThrowing branch July 30, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
bug Bug report / Bug fix size/S
Projects
None yet
Milestone
4.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@snakefoot @304NotModified