Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColoredConsoleTarget - Added DetectOutputRedirected to skip coloring on redirect #3523

Merged
merged 2 commits into from
Jul 24, 2019
Merged

ColoredConsoleTarget - Added DetectOutputRedirected to skip coloring on redirect #3523

merged 2 commits into from
Jul 24, 2019

Conversation

snakefoot
Copy link
Contributor

Notice that target-branch is master

@snakefoot snakefoot force-pushed the ConsoleTargetAutoFlushComment branch 2 times, most recently from 19f24a9 to cd1814f Compare July 23, 2019 17:39
@codecov-io
Copy link

codecov-io commented Jul 23, 2019 •
edited
Loading

Codecov Report

Merging #3523 into master will decrease coverage by <1%.
The diff coverage is 66%.

@@           Coverage Diff           @@
##           master   #3523    +/-   ##
=======================================
- Coverage      80%     80%   -<1%     
=======================================
  Files         361     361            
  Lines       28702   28725    +23     
  Branches     3831    3836     +5     
=======================================
  Hits        22980   22980            
- Misses       4618    4640    +22     
- Partials     1104    1105     +1

@snakefoot snakefoot changed the title ConsoleTarget - Fixed code comment about AutoFlush for standard Console.Out ColoredConsoleTarget - Added DetectOutputRedirected to skip coloring on redirect Jul 23, 2019
@snakefoot snakefoot force-pushed the ConsoleTargetAutoFlushComment branch from 90bb9bf to 7e350ed Compare July 23, 2019 20:17
@304NotModified 304NotModified added this to the 4.6.7 milestone Jul 23, 2019
@304NotModified 304NotModified added enhancement Improvement on existing feature has unittests labels Jul 23, 2019
304NotModified
304NotModified approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@304NotModified
Copy link
Member

(restarted build for unstable test)

@304NotModified
Copy link
Member

yet another flaky test...

@snakefoot snakefoot force-pushed the ConsoleTargetAutoFlushComment branch from 7e350ed to 9a43580 Compare July 24, 2019 06:27
@304NotModified 304NotModified merged commit 4548fc6 into NLog:master Jul 24, 2019
@snakefoot
Copy link
Contributor Author

Updated wiki: https://github.com/NLog/NLog/wiki/ColoredConsole-target

@304NotModified 304NotModified added the documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) label Aug 25, 2019
@snakefoot snakefoot deleted the ConsoleTargetAutoFlushComment branch April 4, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@304NotModified 304NotModified 304NotModified approved these changes

Assignees
No one assigned
Labels
documentation done all docs done (wiki, api docs, lists on nlog-project.org, xmldocs) enhancement Improvement on existing feature size/M
Projects
None yet
Milestone
4.6.7
Development

Successfully merging this pull request may close these issues.
3 participants
@snakefoot @codecov-io @304NotModified