Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve InternalLoggerTests unit test #1252

Merged
merged 2 commits into from
Feb 25, 2016
Merged

improve InternalLoggerTests unit test #1252

merged 2 commits into from
Feb 25, 2016

Conversation

304NotModified
Copy link
Member

better scoping, flush before test, added helper method

@304NotModified 304NotModified changed the title improve unit test WriteToStringWriterWithArgsTests improve InternalLoggerTests unit test Feb 19, 2016
@304NotModified
improve unit tests
526a843 
better scoping, flush before test, added helper method
@304NotModified
Improve unit tests
1b3447c
@304NotModified 304NotModified force-pushed the improve-InternalLoggerTests branch from ca899a1 to 1b3447c Compare February 24, 2016 18:01
@codecov-io
Copy link

Current coverage is 74.62%

Merging #1252 into master will increase coverage by +0.02% as of 1b3447c

@@            master   #1252   diff @@
======================================
  Files          267     267       
  Stmts        15407   15407       
  Branches      1615    1615       
  Methods          0       0       
======================================
+ Hit          11494   11497     +3
- Partial        378     379     +1
+ Missed        3535    3531     -4

Review entire Coverage Diff as of 1b3447c

Uncovered Suggestions

  1. +0.09% via ...gingConfiguration.cs#282...295
  2. +0.09% via ...gingConfiguration.cs#248...261
  3. +0.08% via ...argets/FileTarget.cs#1704...1716
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Feb 25, 2016
@304NotModified
Merge pull request #1252 from NLog/improve-InternalLoggerTests
f2ff5c1 
improve InternalLoggerTests unit test
@304NotModified 304NotModified merged commit f2ff5c1 into master Feb 25, 2016
@304NotModified 304NotModified added this to the 4.3 milestone Feb 25, 2016
@304NotModified 304NotModified deleted the improve-InternalLoggerTests branch April 12, 2016 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unit-tests
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@304NotModified @codecov-io