-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration API Dependency on System.Drawing in Xamarin #955
Comments
Which NLog version are you using? I think we removed System.Drawing in NLog.dll in one of the latest versions (there is PR for. have to find it) |
|
But do you use the NLog.Windows.Forms extension or other extensions? |
Negative, just the core library. |
OK clear. Do you know which .Net version xamarin chooses? You used the nuget package? |
I see indeed that system.drawing is still referenced. #754 I will check this weekend why, and fix it if possible. If I can't be fixed, we need to have a separate xamarin build. Can you help me with that? (nuspec and testing), as I never used xamarin. |
Xam.Mac uses a broad subset of the 4.5 framework (based on mono), rendering most standard packages usable. The only iffy things I have seen are with some reflection components, and the As far as I can tell, this may be a relic of the Pulled latest and performed a reference check with the 4.5 project, and found no usages inside the core library, and built fine. Will repackage and test locally in the morning to verify then will PR in. |
I also checked, it seems not be used indeed. If you fix a PR, then I will release 4.1.3 soon :) |
OR maybe 4.2. Doubting...only small things added, but according to semver it should be 4.2 and not 4.1.3 |
gives issues in Xamarin, see #955
Just about to remove it and noticed the change. Thanks. |
This is will be released this week. |
I am using NLog in combination with
Common.Logging
, and have facaded logging throughout my library dependencies to use NLog at the consumer application level.At this stage, NLog works well in Windows implementations, but falls over when using the Configuration API with the Xamarin.Mac framework (not Mono, rather Xam's official deviation) citing a failure to load
System.Drawing
which is a problem I have faced before.System.Drawing
is No longer supported as of the new Unified API.As I understand it, this is an essential reference for the
NLog.Windows.Forms
extension, however after a quick look don't see any references outside of that. This makes me wonder wether the core csproj files require this reference.If it is required, does anyone have a sneaky little workaround, short of changing and recompiling?
Cheers
The text was updated successfully, but these errors were encountered: