Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced LoadConfigurationFromSection on ISetupBuilder #412

Merged

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 31, 2020

Superseded #410

Updated example:

                LogManager.Setup()
                    .SetupExtensions(s => s.AutoLoadAssemblies(false))
                    .LoadConfigurationFromSection(config);

@codecov-io
Copy link

Codecov Report

Merging #412 into master will decrease coverage by 0.15%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
- Coverage   82.45%   82.29%   -0.16%     
==========================================
  Files          14       14              
  Lines        1197     1192       -5     
  Branches      194      195       +1     
==========================================
- Hits          987      981       -6     
  Misses        141      141              
- Partials       69       70       +1
Impacted Files Coverage Δ
...Logging/Config/SetupExtensionsBuilderExtensions.cs 100% <100%> (ø)
...xtensions.Logging/Config/SetupBuilderExtensions.cs 88.88% <80%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8787454...e8993e9. Read the comment docs.

@304NotModified
Copy link
Member

This is an API breaking change? The revert?

@snakefoot
Copy link
Contributor Author

We have not released anything yet. Me trying out the LogManager.Setup()-fluent-API.

And decided that this works better for my eyes :)

@304NotModified
Copy link
Member

ow yes indeed

@304NotModified 304NotModified added this to the 1.6.3 milestone Mar 31, 2020
@304NotModified
Copy link
Member

This is indeed nicer to read :)

@304NotModified 304NotModified merged commit 4bd3bcb into NLog:master Mar 31, 2020
@304NotModified 304NotModified changed the title Reverted #410 and instead introduced LoadNLogConfigFromSection on ISetupBuilder Introduced LoadNLogConfigFromSection on ISetupBuilder Apr 14, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Apr 26, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request Apr 26, 2020
snakefoot added a commit to snakefoot/NLog.Extensions.Logging that referenced this pull request May 10, 2020
304NotModified pushed a commit that referenced this pull request May 11, 2020
@304NotModified 304NotModified changed the title Introduced LoadNLogConfigFromSection on ISetupBuilder Introduced LoadConfigurationFromSection on ISetupBuilder May 11, 2020
@304NotModified
Copy link
Member

note renamed before release in #418. Example and title has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants