Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NLogProviderOptions.ShutdownOnDispose #314

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Conversation

304NotModified
Copy link
Member

Fixes #313

@codecov-io
Copy link

codecov-io commented Jul 12, 2019

Codecov Report

Merging #314 into dev will decrease coverage by 0.24%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #314      +/-   ##
==========================================
- Coverage   81.69%   81.44%   -0.25%     
==========================================
  Files          12       12              
  Lines        1087     1094       +7     
  Branches      190      191       +1     
==========================================
+ Hits          888      891       +3     
- Misses        138      141       +3     
- Partials       61       62       +1
Impacted Files Coverage Δ
....Extensions.Logging/Logging/NLogProviderOptions.cs 100% <100%> (ø) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 90.14% <42.85%> (-5.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db58f7...e27f255. Read the comment docs.

Copy link
Contributor

@snakefoot snakefoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NLogLoggingConfiguration for shutdown on dispose
3 participants