Unjostable queries for configured upstreams #1201
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft the idea of unjostable queries if upstreams are explicitly configured.
May prove useful if Unbound's general upstream connectivity is problematic and request list keeps growing.
Then a client query for a configured stub-zone for example would not be eligible to be replaced but instead allowed to run to completion.
That would need explicit configuration and not what this PR is initially doing, i.e., treating every configured upstream as non-eligible for replacement.
A better configuration would be to define a custom (higher) jostle-timeout for those queries to persist for a while longer before being replaced.