refactor: use api v2 #91
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Serein207
force-pushed
the
refactor/api-v2
branch
3 times, most recently
from
2ea137f
to
4e309f7
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
3 similar comments
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ArcticLampyrid
force-pushed
the
dev
branch
2 times, most recently
from
3f6a54e
to
ade37e4
Compare
| @@ -34,16 +34,15 @@ inline time_t parseIso8601Utc(const char* date) { | |||
| struct tm tt = {0}; | |||
| double seconds; | |||
| if (sscanf(date, | |||
| "%04d-%02d-%02dT%02d:%02d:%lfZ", | |||
| "%04d-%02d-%02dT%02d:%02d:%02d", | |||
There was a problem hiding this comment.
- 按照标准，秒部分可能带小数（当然因为后端固定所以这个不考虑也问题不大
- 末尾的
Z是 UTC 时区的标志，如果服务器返回的数据不带Z的话，那可能需要重新检查并额外约定时区（Apifox 里面有写吗？
Serein207
force-pushed
the
refactor/api-v2
branch
from
76f676a
to
3884281
Compare
Serein207
force-pushed
the
refactor/api-v2
branch
from
3884281
to
a627922
Compare
Serein207
force-pushed
the
refactor/api-v2
branch
3 times, most recently
from
fd68dc2
to
13e7dba
Compare
fix: first date time of week fix: get first date of week
refactor: drop v1 api
Serein207
force-pushed
the
refactor/api-v2
branch
from
13e7dba
to
20858ac
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eventIdtype toeventId_t(aliasstd::string)