Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the page style of google search results #74

Closed
wants to merge 9 commits into from

Conversation

iamrishab07
Copy link
Contributor

Modify the display results on the search page .
Remove all the leading "Index of /" portions to make the result title more appropriate.
Here's a screenshot of "Fearch" results after changes .

screenshot 25

Fix #45

@iamrishab07
Copy link
Contributor Author

@PaliwalSparsh I was having problem performing rollback on git terminal . Thus made changes in the code and here is the new PR regarding #45 only.

@iamrishab07
Copy link
Contributor Author

@PaliwalSparsh please have a look . Here's the error message .
screenshot 26

This same piece of code showed no error in some previous commit ,but this time its different.
I'm clueless .

@PaliwalSparsh
Copy link
Collaborator

@iamrishab07 instead of i++ use i+=1, this would work.

Reason why i++ does not work can be found here http://eslint.org/docs/rules/no-plusplus.

Also, fixing this PR through back and forth reviewing might take some time. If you are interested in the GSOC Heat you might want to solve a difficulty new comer issue like this one #71 and send in the proposal.

This PR is really good but would require some more work before getting merged. This does not mean it is a lot of work. But we would need to sort these -

  1. Fixing on the style of how we want the FTP links to appear(removing index of is a good start).
  2. Presently this PR contains too many unnecessary commits(9 commits) we will squash them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants