-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added I'm feeling lucky button and made the display of google search result more meaningful #69
Conversation
@iamrishab07 you seem to have errors on your PR see https://travis-ci.org/NIT-dgp/chrome-search-extension/builds/194849346 for more details |
also it's always nice to show screenshots of work in action whenever making a PR of such sorts :D |
@iamrishab07 i meant screenshots of "Fearch" working with the new changes you added :P and you can do |
@iamrishab07 nice @PaliwalSparsh will get back to you shortly :) |
@iamrishab07 Thanks for the PR 😄 Firstly it would be great if you try to have different PRs for different issues. I hope you will understand the reason for it by the end of this comment. Actually both #35 and #45 were #35 was just not about adding the button, the google's url query for the #45 is where this PR is going really great. I would really appreciate if you Moral - Had you done both the issues on different branches from the beginning you would have not to do the extra work. #35 is also a good issue to work on - you can also make a new separate PR for it and we shall have discussion on it too. Again thanks for your work 😄 |
function lucky(){ | ||
var lButton = document.getElementById("imfl"); | ||
lButton.addEventListener("click", function () { | ||
window.open("https://www.google.com/doodles"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everytime the window that gets open is that of doodles page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah , whenever the search query is empty ,this code will work for that only.
@PaliwalSparsh I'm working on it .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamrishab07 Great, do let me know if you have any problem.
Add I'm feeling lucky button at the footer.
Fix #35
Modify googleCS.js to make the titles of the google search results more meaningful by removing the leading "Index of " part from the title.
Fix #45